Re: [PATCH v3 00/41] Mirror map JIT memory for TCG

[no-reply]

Patchew URL: 
20201106032921.600200-1-richard.henderson@linaro.org/">https://patchew.org/QEMU/20201106032921.600200-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201106032921.600200-1-richard.henderson@linaro.org
Subject: [PATCH v3 00/41] Mirror map JIT memory for TCG

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/20201106032921.600200-1-richard.henderson@linaro.org -> 
patchew/20201106032921.600200-1-richard.henderson@linaro.org
Switched to a new branch 'test'
170f310 tcg: Constify TCGLabelQemuLdst.raddr
c336494 tcg: Constify tcg_code_gen_epilogue
a009e99 tcg: Remove TCG_TARGET_SUPPORT_MIRROR
545feb7 tcg/arm: Support split-wx code generation
a873c61 tcg/mips: Support split-wx code generation
7f12d40 tcg/mips: Do not assert on relocation overflow
200ecb3 accel/tcg: Add mips support to alloc_code_gen_buffer_splitwx_memfd
edd72db tcg/riscv: Support split-wx code generation
1c6764d tcg/riscv: Remove branch-over-branch fallback
63883fc tcg/riscv: Fix branch range checks
dff34e0 tcg/s390: Support split-wx code generation
8d88879 tcg/s390: Use tcg_tbrel_diff
f0fea63 tcg/sparc: Support split-wx code generation
5a837a3 tcg/sparc: Use tcg_tbrel_diff
684c281 tcg/ppc: Support split-wx code generation
a254bfd tcg/ppc: Use tcg_out_mem_long to reset TCG_REG_TB
4c4f647 tcg/ppc: Use tcg_tbrel_diff
5f81f0e tcg: Introduce tcg_tbrel_diff
1cab418 tcg/tci: Push const down through bytecode reading
c55a8c0 disas: Push const down through host disasassembly
55b926c tcg/aarch64: Support split-wx code generation
aef71b4 tcg/aarch64: Implement flush_idcache_range manually
548fc79 tcg/aarch64: Use B not BL for tcg_out_goto_long
6cbd22a tcg/i386: Support split-wx code generation
fe36cad tcg: Return the TB pointer from the rx region from exit_tb
ef96a10 accel/tcg: Support split-wx for darwin/iOS with vm_remap
fed5e19 accel/tcg: Support split-wx for linux with memfd
caaf645 tcg: Add --accel tcg,split-wx property
f93ae22 tcg: Use Error with alloc_code_gen_buffer
b6992b5 tcg: Make tb arg to synchronize_from_tb const
043973b tcg: Make DisasContextBase.tb const
1d83486 tcg: Adjust tb_target_set_jmp_target for split-wx
eec18a6 tcg: Adjust tcg_register_jit for const
65e76b9 tcg: Adjust tcg_out_label for const
44975a9 tcg: Adjust tcg_out_call for const
c3e1e5d tcg: Adjust TCGLabel for const
72ac21e tcg: Introduce tcg_splitwx_to_{rx,rw}
3e322da tcg: Add in_code_gen_buffer
ccb0c48 tcg: Move tcg epilogue pointer out of TCGContext
09ef808 tcg: Move tcg prologue pointer out of TCGContext
e488e58 tcg: Enhance flush_icache_range with separate data pointer

=== OUTPUT BEGIN ===
1/41 Checking commit e488e58096f9 (tcg: Enhance flush_icache_range with 
separate data pointer)
2/41 Checking commit 09ef8082ce7f (tcg: Move tcg prologue pointer out of 
TCGContext)
3/41 Checking commit ccb0c482bf3e (tcg: Move tcg epilogue pointer out of 
TCGContext)
4/41 Checking commit 3e322da5de89 (tcg: Add in_code_gen_buffer)
5/41 Checking commit 72ac21e27103 (tcg: Introduce tcg_splitwx_to_{rx,rw})
6/41 Checking commit c3e1e5d3a470 (tcg: Adjust TCGLabel for const)
7/41 Checking commit 44975a9cbb02 (tcg: Adjust tcg_out_call for const)
8/41 Checking commit 65e76b95a029 (tcg: Adjust tcg_out_label for const)
9/41 Checking commit eec18a607903 (tcg: Adjust tcg_register_jit for const)
10/41 Checking commit 1d83486ee180 (tcg: Adjust tb_target_set_jmp_target for 
split-wx)
11/41 Checking commit 043973b272b1 (tcg: Make DisasContextBase.tb const)
12/41 Checking commit b6992b579570 (tcg: Make tb arg to synchronize_from_tb 
const)
13/41 Checking commit f93ae2267092 (tcg: Use Error with alloc_code_gen_buffer)
14/41 Checking commit caaf645ec574 (tcg: Add --accel tcg,split-wx property)
15/41 Checking commit fed5e19b3c0c (accel/tcg: Support split-wx for linux with 
memfd)
16/41 Checking commit ef96a10480c7 (accel/tcg: Support split-wx for darwin/iOS 
with vm_remap)
ERROR: externs should be avoided in .c files
#24: FILE: accel/tcg/translate-all.c:1172:
+extern kern_return_t mach_vm_remap(vm_map_t target_task,

total: 1 errors, 0 warnings, 80 lines checked

Patch 16/41 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/41 Checking commit fe36cad8bf7d (tcg: Return the TB pointer from the rx 
region from exit_tb)
18/41 Checking commit 6cbd22af41aa (tcg/i386: Support split-wx code generation)
19/41 Checking commit 548fc7975cc4 (tcg/aarch64: Use B not BL for 
tcg_out_goto_long)
20/41 Checking commit aef71b442d41 (tcg/aarch64: Implement flush_idcache_range 
manually)
21/41 Checking commit 55b926c57a1b (tcg/aarch64: Support split-wx code 
generation)
22/41 Checking commit c55a8c0c489d (disas: Push const down through host 
disasassembly)
23/41 Checking commit 1cab4182fb0e (tcg/tci: Push const down through bytecode 
reading)
24/41 Checking commit 5f81f0e007d9 (tcg: Introduce tcg_tbrel_diff)
25/41 Checking commit 4c4f647cce7b (tcg/ppc: Use tcg_tbrel_diff)
26/41 Checking commit a254bfdddaf2 (tcg/ppc: Use tcg_out_mem_long to reset 
TCG_REG_TB)
27/41 Checking commit 684c281aa228 (tcg/ppc: Support split-wx code generation)
28/41 Checking commit 5a837a3879fe (tcg/sparc: Use tcg_tbrel_diff)
29/41 Checking commit f0fea6377b00 (tcg/sparc: Support split-wx code generation)
30/41 Checking commit 8d88879495b6 (tcg/s390: Use tcg_tbrel_diff)
31/41 Checking commit dff34e06dd91 (tcg/s390: Support split-wx code generation)
32/41 Checking commit 63883fcc4015 (tcg/riscv: Fix branch range checks)
33/41 Checking commit 1c6764de6cda (tcg/riscv: Remove branch-over-branch 
fallback)
34/41 Checking commit edd72db707ca (tcg/riscv: Support split-wx code generation)
35/41 Checking commit 200ecb3d750f (accel/tcg: Add mips support to 
alloc_code_gen_buffer_splitwx_memfd)
WARNING: architecture specific defines should be avoided
#25: FILE: accel/tcg/translate-all.c:1143:
+#ifdef __mips__

WARNING: architecture specific defines should be avoided
#43: FILE: accel/tcg/translate-all.c:1160:
+#ifdef __mips__

total: 0 errors, 2 warnings, 68 lines checked

Patch 35/41 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/41 Checking commit 7f12d40b3470 (tcg/mips: Do not assert on relocation 
overflow)
37/41 Checking commit a873c6132612 (tcg/mips: Support split-wx code generation)
38/41 Checking commit 545feb70c9a8 (tcg/arm: Support split-wx code generation)
39/41 Checking commit a009e993d945 (tcg: Remove TCG_TARGET_SUPPORT_MIRROR)
40/41 Checking commit c33649448a69 (tcg: Constify tcg_code_gen_epilogue)
41/41 Checking commit 170f3100faa4 (tcg: Constify TCGLabelQemuLdst.raddr)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201106032921.600200-1-richard.henderson@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20201106032921.600200-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com