Re: [RFC PATCH 10/15] meson.build: clean-up summary reporting of XEN and it's features

[Philippe Mathieu-Daudé]

On 11/5/20 6:51 PM, Alex Bennée wrote:
> Report XEN support along with the rest of the accelerators. Repurposed
> the existing Xen support line to display details about the control API
> version and the additional enabled features.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  meson.build | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 46e4c2fc3a..79b74fbda7 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2078,8 +2078,15 @@ if vnc.found()
>    summary_info += {'VNC JPEG support':  jpeg.found()}
>    summary_info += {'VNC PNG support':   png.found()}
>  endif
> -summary_info += {'xen support':       
> config_host.has_key('CONFIG_XEN_BACKEND')}
>  if config_host.has_key('CONFIG_XEN_BACKEND')
> +  xen_features = ['backend']
> +  if config_all.has_key('CONFIG_XEN_HVM')
> +    xen_features += 'HVM'
> +  endif
> +  if config_all.has_key('CONFIG_XEN_PCI_PASSTHROUGH')
> +    xen_features += 'PCI Passthrough'
> +  endif
> +  summary_info += {'xen features':      ' '.join(xen_features)}

Maybe ','.join, as ' ' already in 'PCI Passthrough'.

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>    summary_info += {'xen ctrl version':  
> config_host['CONFIG_XEN_CTRL_INTERFACE_VERSION']}
>  endif
>  summary_info += {'brlapi support':    config_host.has_key('CONFIG_BRLAPI')}
> @@ -2092,6 +2099,7 @@ summary_info += {'Linux io_uring support': 
> config_host.has_key('CONFIG_LINUX_IO_
>  summary_info += {'ATTR/XATTR support': config_host.has_key('CONFIG_ATTR')}
>  summary_info += {'Install blobs':     get_option('install_blobs')}
>  summary_info += {'KVM support':       config_all.has_key('CONFIG_KVM')}
> +summary_info += {'XEN support':       config_all.has_key('CONFIG_XEN')}
>  summary_info += {'HAX support':       config_all.has_key('CONFIG_HAX')}
>  summary_info += {'HVF support':       config_all.has_key('CONFIG_HVF')}
>  summary_info += {'WHPX support':      config_all.has_key('CONFIG_WHPX')}
>