qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/arm/virt enable support for virtio-mem


From: no-reply
Subject: Re: [PATCH] hw/arm/virt enable support for virtio-mem
Date: Thu, 5 Nov 2020 09:18:48 -0800 (PST)

Patchew URL: 
20201105171144.560612-1-Jonathan.Cameron@huawei.com/">https://patchew.org/QEMU/20201105171144.560612-1-Jonathan.Cameron@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201105171144.560612-1-Jonathan.Cameron@huawei.com
Subject: [PATCH] hw/arm/virt enable support for virtio-mem

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/20201105171144.560612-1-Jonathan.Cameron@huawei.com -> 
patchew/20201105171144.560612-1-Jonathan.Cameron@huawei.com
Switched to a new branch 'test'
03ce0eb hw/arm/virt enable support for virtio-mem

=== OUTPUT BEGIN ===
WARNING: line over 80 characters
#89: FILE: hw/arm/virt.c:2289:
+        error_setg(errp, "hotplug of virtio-mem based memory devices not 
supported"

ERROR: trailing whitespace
#113: FILE: hw/arm/virt.c:2313:
+        virt_virtio_md_pci_pre_plug(hotplug_dev, dev, errp);        $

ERROR: space required before the open brace '{'
#173: FILE: hw/arm/virt.c:2464:
+        object_dynamic_cast(OBJECT(dev), TYPE_VIRTIO_MEM_PCI)){

ERROR: space prohibited between function name and open parenthesis '('
#200: FILE: hw/virtio/virtio-mem.c:56:
+#elif defined (TARGET_AARCH64)

total: 3 errors, 1 warnings, 138 lines checked

Commit 03ce0eb928fb (hw/arm/virt enable support for virtio-mem) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201105171144.560612-1-Jonathan.Cameron@huawei.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201105171144.560612-1-Jonathan.Cameron@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

reply via email to

[Prev in Thread] Current Thread [Next in Thread]