[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] block: Fix integer promotion error in bdrv_getlength()
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] block: Fix integer promotion error in bdrv_getlength() |
|
Date: |
Thu, 5 Nov 2020 09:39:18 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 11/5/20 7:26 AM, Max Reitz wrote:
>> I actually preferred the v1 solution, rather than this v2, as it avoided
>> a cast.
>
> I don’t, because it doesn’t make the ?: go away, so I prefer the less
> invasive version.
>
> If you want to send your suggested version (that drops both ?:), I’m
> happy to take that instead.
Will do.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org