Re: [PATCH 1/3] hw/usb/ccid: remove references to NSS

[Philippe Mathieu-Daudé]

On 11/4/20 2:19 PM, Daniel P. Berrangé wrote:
> The NSS package was previously pre-requisite for building CCID related
> features, however, this became obsolete when the libcacard library was
> spun off to a separate project:
> 
>     commit 7b02f5447c64d1854468f758398c9f6fe9e5721f
>     Author: Marc-André Lureau <marcandre.lureau@redhat.com>
>     Date:   Sun Aug 30 11:48:40 2015 +0200
> 
>         libcacard: use the standalone project
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  .travis.yml                                | 14 +++++++-------
>  docs/ccid.txt                              | 15 +++++++--------
>  scripts/coverity-scan/coverity-scan.docker |  1 -
>  tests/docker/dockerfiles/centos7.docker    |  1 +
>  tests/docker/dockerfiles/centos8.docker    |  1 +
>  tests/docker/dockerfiles/fedora.docker     |  2 +-
>  6 files changed, 17 insertions(+), 17 deletions(-)
...

> diff --git a/docs/ccid.txt b/docs/ccid.txt
> index c7fda6d07d..1baf03e29b 100644
> --- a/docs/ccid.txt
> +++ b/docs/ccid.txt
> @@ -34,15 +34,14 @@ reader and smart card (i.e. not backed by a physical 
> device) using this device.
>  
>  2. Building
>  
> -The cryptographic functions and access to the physical card is done via NSS.
> -
> -Installing NSS:
> +The cryptographic functions and access to the physical card is done via the
> +libcacard library, whose development package must be installed prior to
> +building QEMU:
>  
>  In redhat/fedora:
> -    yum install nss-devel
> -In ubuntu/debian:
> -    apt-get install libnss3-dev
> -    (not tested on ubuntu)
> +    yum install libcacard-devel
> +In ubuntu:
> +    apt-get install libcacard-dev
>  
>  Configuring and building:
>      ./configure --enable-smartcard && make
> @@ -51,7 +50,7 @@ Configuring and building:
>  3. Using ccid-card-emulated with hardware
>  
>  Assuming you have a working smartcard on the host with the current
> -user, using NSS, qemu acts as another NSS client using ccid-card-emulated:
> +user, using libcacard, qemu acts as another client using ccid-card-emulated:

Maybe replace 'qemu' by 'QEMU' (another instance line 125).

Otherwise:

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks.