Re: [PATCH v2] qapi, qemu-options: make all parsing visitors parse boolean options the same

[Markus Armbruster]

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Wed, Nov 04, 2020 at 12:31:40PM +0100, Paolo Bonzini wrote:
>> On 04/11/20 09:29, Markus Armbruster wrote:
>> > >   It only hurts in the odd case of a boolean option becoming on/off/auto
>> > > or on/off/split.
>> > Another argument for deprecating values other than "on" and "off".
>> 
>> Unfortunately I'm fairly sure that I've seen yes/no in use.

If it wasn't, we'd remove rather than deprecate :)

>>                                                              I can buy
>> insta-removal (not deprecation) of case-insensitivity.

Since case-insensitivity is undocumented, and we're not aware of actual
use, no objection.

> Seems a couple of example usages are my fault as I documented them :-(
>
> docs/system/vnc-security.rst:     -object 
> tls-creds-x509,id=tls0,dir=/etc/pki/qemu,endpoint=server,verify-peer=yes \
> docs/system/vnc-security.rst:     -object 
> tls-creds-x509,id=tls0,dir=/etc/pki/qemu,endpoint=server,verify-peer=yes \
> docs/system/vnc-security.rst:     -object 
> tls-creds-x509,id=tls0,dir=/etc/pki/qemu,endpoint=server,verify-peer=yes \
> include/authz/listfile.h: *           
> filename=/etc/qemu/myvm-vnc.acl,refresh=yes
> qemu-options.hx:    ``-object 
> authz-listfile,id=id,filename=path,refresh=yes|no``
> qemu-options.hx:                 -object 
> authz-simple,id=auth0,filename=/etc/qemu/vnc-sasl.acl,refresh=yes \\
>
> We should fix thos docs in QEMU at least, and unfortunately it seems I
> missed that libvirt did use  verify-peer=yes

Yes, please.