[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-5.2 v3 3/4] gitlab-ci: Add a job to cover the --without-d

From: Wainer dos Santos Moschetta
Subject: Re: [PATCH-for-5.2 v3 3/4] gitlab-ci: Add a job to cover the --without-default-devices config
Date: Wed, 4 Nov 2020 10:12:09 -0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 11/4/20 9:57 AM, Philippe Mathieu-Daudé wrote:
We test './configure --without-default-devices' since commit
20885b5b169 (".travis.yml: test that no-default-device builds
do not regress") in Travis-CI.

Since having a single CI to look at is easier, and GitLab-CI
is the preferred one, add the equivalent job there.

As smoke test, run the qtests on the AVR target. Since the
boards are simple SoC, there is not issue with unavailable
default devices there.
Also include the m68k target which works fine.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
  .gitlab-ci.yml | 7 +++++++
  1 file changed, 7 insertions(+)

Looks good to me.

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 3b15ae5c302..e4eba96ff34 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -262,6 +262,13 @@ build-user-plugins:
      MAKE_CHECK_ARGS: check-tcg
    timeout: 1h 30m
+  <<: *native_build_job_definition
+  variables:
+    IMAGE: ubuntu2004
+    CONFIGURE_ARGS: --without-default-devices --disable-user --disable-tools 
+    MAKE_CHECK_ARGS: check-qtest-avr check-qtest-m68k
    <<: *native_build_job_definition

reply via email to

[Prev in Thread] Current Thread [Next in Thread]