[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2 46/72] python/qmp: Fix type of SocketAddrT

From: John Snow
Subject: [PATCH v2 46/72] python/qmp: Fix type of SocketAddrT
Date: Tue, 3 Nov 2020 19:35:36 -0500

This is an integer, not a string. We didn't catch this before because we
have not been type checking any of the clients that use this, and it was
self-consistent enough.

Mypy was not introspecting into the socket() interface to realize we
were passing a bad type. Fixed now.

Signed-off-by: John Snow <jsnow@redhat.com>
 python/qemu/qmp/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/qemu/qmp/__init__.py b/python/qemu/qmp/__init__.py
index 7355a558796f..dd211e3f6511 100644
--- a/python/qemu/qmp/__init__.py
+++ b/python/qemu/qmp/__init__.py
@@ -49,7 +49,7 @@
 # {} is the QMPReturnValue.
-InternetAddrT = Tuple[str, str]
+InternetAddrT = Tuple[str, int]
 UnixAddrT = str
 SocketAddrT = Union[InternetAddrT, UnixAddrT]

reply via email to

[Prev in Thread] Current Thread [Next in Thread]