Re: [PULL 00/38] pc,pci,vhost,virtio: fixes

[Peter Maydell]

On Tue, 3 Nov 2020 at 14:34, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> The following changes since commit c7a7a877b716cf14848f1fd5c754d293e2f8d852:
>
>   Merge remote-tracking branch 
> 'remotes/pmaydell/tags/pull-target-arm-20201102' into staging (2020-11-03 
> 10:38:05 +0000)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to cf0bdd0a703911f80fc645dec97f17c4415af267:
>
>   vhost-user-blk-test: fix races by using fd passing (2020-11-03 09:19:12 
> -0500)
>
> ----------------------------------------------------------------
> pc,pci,vhost,virtio: fixes
>
> Lots of fixes all over the place.
> virtio-mem and virtio-iommu patches are kind of fixes but
> it seems better to just make them behave sanely than
> try to educate users about the limitations ...
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> ----------------------------------------------------------------

Fails to compile on 32-bit host:

../../hw/vfio/common.c: In function 'vfio_listener_region_del':
../../hw/vfio/common.c:953:20: error: invalid operands to binary ==
(have 'Int128 {aka struct Int128}' and 'Int128 {aka struct Int128}')
         if (llsize == int128_2_64()) {
                    ^~ ~~~~~~~~~~~~~

This needs to use int128_eq() to do the comparison.

thanks
-- PMM