Re: [PULL v3 00/12] qemu-ga patch queue for soft-freeze

[Peter Maydell]

On Tue, 3 Nov 2020 at 02:44, Michael Roth <michael.roth@amd.com> wrote:
>
> Hi Peter,
>
> Sorry to get these out so late, for some inexplicable reason my email
> client decided to flag all responses v1 as spam and I didn't notice
> until I double-checked the archives this morning.
>
> I've fixed the gcc-on-BSD and clang-on-linux issues you pointed out
> (PATCH 6) and added proper test coverage for both.
>
> Also, the qga-ssh-test unit test introduced in this series triggers a
> failure in Gitlab CI build-oss-fuzz test. This seems to be due to a
> memory leak in GLib itself when G_TEST_OPTION_ISOLATE_DIRS option is
> passed to g_test_init(). I verified the unit test doesn't introduce any
> leaks when run without g_test* harness. Since G_TEST_OPTION_ISOLATE_DIRS
> is currently needed to safely run the qga-ssh-test, I've disabled it for
> now (PATCH 9 and 12) until we figure out solution.
>
> And finally (hopefully), I addressed the checkpatch warning regarding
> disallowed use of various g_assert_* macros. I previously thought they
> were just noise until Markus pointed out commit 6e9389563e.
>
> Sorry for all the noise,
>
> Mike
>
> The following changes since commit 2c6605389c1f76973d92b69b85d40d94b8f1092c:
>
>   Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20201101.0' 
> into staging (2020-11-02 09:54:00 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/mdroth/qemu.git tags/qga-pull-2020-10-27-v3-tag
>
> for you to fetch changes up to cad97c08a1c17830d77a46780088bc0199df89d1:
>
>   qga: add ssh-get-authorized-keys (2020-11-02 20:04:13 -0600)
>
> ----------------------------------------------------------------
> qemu-ga patch queue for soft-freeze
>
> * add guest-get-disks for w32/linux
> * add guest-{add,remove,get}-authorized-keys
> * fix API violations and schema documentation inconsistencies with
>   recently-added guest-get-devices
>
> v3:
> - fix checkpatch errors regarding disallowed usages of g_assert*
>   macros and other warnings
>
> v2:
> - fix BSD build error due to missing stub for guest_get_disks
> - fix clang build error on linux due to unused variable
> - disable qga-ssh-test for now due to a memory leak within GLib when
>   G_TEST_OPTION_ISOLATE_DIRS is passed to g_test_init() since it
>   break Gitlab CI build-oss-fuzz test
> - rebased and re-tested on master
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2
for any user-visible changes.

-- PMM