[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug 1902470] Re: migration with TLS-MultiFD is stuck when the dst-l
From: |
Zheng Chuan |
Subject: |
Re: [Bug 1902470] Re: migration with TLS-MultiFD is stuck when the dst-libvirtd service restarts |
Date: |
Tue, 3 Nov 2020 17:56:52 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 2020/11/3 17:29, Daniel Berrange wrote:
> This looks to me like a significant implementation flaw in the QEMU
> code. Both src and dst QEMU appear to be running code from the main
> event loop, and they appear to be doing blocking I/O operations. This is
> very bad as we should never have anything running in the main event loop
> thread that is able to block on I/O.
>
Well, the tls handshake seems to be blocking I/O.
> So to solve this something needs to be done to make sure the I/O is
> either non-blocking, or if it has to be blocking, then it needs to be
> offloaded to a background thread.
>
Yes, i agree.
Since we do multifd tls handshake in main thread through multifd_save_setup(),
maybe
we need to make socket_send_channel_create() to be a background thread other
than qio_channel_socket_connect_async()?
Besides,the hang problem itself still need to be figured out and solved...
--
Regards.
Chuan
[Bug 1902470] Re: migration with TLS-MultiFD is stuck when the dst-libvirtd service restarts, Daniel Berrange, 2020/11/03
- Re: [Bug 1902470] Re: migration with TLS-MultiFD is stuck when the dst-libvirtd service restarts,
Zheng Chuan <=
[Bug 1902470] Re: migration with TLS-MultiFD is stuck when the dst-libvirtd service restarts, Chuan Zheng, 2020/11/05
[Bug 1902470] Re: migration with TLS-MultiFD is stuck when the dst-libvirtd service restarts, Chuan Zheng, 2020/11/09
[Bug 1902470] Re: migration with TLS-MultiFD is stuck when the dst-libvirtd service restarts, Chuan Zheng, 2020/11/09
[Bug 1902470] Re: migration with TLS-MultiFD is stuck when the dst-libvirtd service restarts, Chuan Zheng, 2020/11/12