[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH-for-5.2 v3 7/7] util/vfio-helpers: Assert offset is aligned to pa
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH-for-5.2 v3 7/7] util/vfio-helpers: Assert offset is aligned to page size |
Date: |
Tue, 3 Nov 2020 03:07:33 +0100 |
mmap(2) states:
'offset' must be a multiple of the page size as returned
by sysconf(_SC_PAGE_SIZE).
Add an assertion to be sure we don't break this contract.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
util/vfio-helpers.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c
index 73f7bfa7540..804768d5c66 100644
--- a/util/vfio-helpers.c
+++ b/util/vfio-helpers.c
@@ -162,6 +162,7 @@ void *qemu_vfio_pci_map_bar(QEMUVFIOState *s, int index,
Error **errp)
{
void *p;
+ assert(QEMU_IS_ALIGNED(offset, qemu_real_host_page_size));
assert_bar_index_valid(s, index);
p = mmap(NULL, MIN(size, s->bar_region_info[index].size - offset),
prot, MAP_SHARED,
--
2.26.2
- [PATCH-for-5.2 v3 0/7] util/vfio-helpers: Generic code strengthening, Philippe Mathieu-Daudé, 2020/11/02
- [PATCH-for-5.2 v3 1/7] util/vfio-helpers: Improve reporting unsupported IOMMU type, Philippe Mathieu-Daudé, 2020/11/02
- [PATCH-for-5.2 v3 2/7] util/vfio-helpers: Trace PCI I/O config accesses, Philippe Mathieu-Daudé, 2020/11/02
- [PATCH-for-5.2 v3 3/7] util/vfio-helpers: Trace PCI BAR region info, Philippe Mathieu-Daudé, 2020/11/02
- [PATCH-for-5.2 v3 4/7] util/vfio-helpers: Trace where BARs are mapped, Philippe Mathieu-Daudé, 2020/11/02
- [PATCH-for-5.2 v3 5/7] util/vfio-helpers: Improve DMA trace events, Philippe Mathieu-Daudé, 2020/11/02
- [PATCH-for-5.2 v3 6/7] util/vfio-helpers: Convert vfio_dump_mapping to trace events, Philippe Mathieu-Daudé, 2020/11/02
- [PATCH-for-5.2 v3 7/7] util/vfio-helpers: Assert offset is aligned to page size,
Philippe Mathieu-Daudé <=
- Re: [PATCH-for-5.2 v3 0/7] util/vfio-helpers: Generic code strengthening, Stefan Hajnoczi, 2020/11/03
- Re: [PATCH-for-5.2 v3 0/7] util/vfio-helpers: Generic code strengthening, Auger Eric, 2020/11/03