[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 04/12] qga: Flatten simple union GuestDeviceId
From: |
Michael Roth |
Subject: |
[PULL v2 04/12] qga: Flatten simple union GuestDeviceId |
Date: |
Mon, 2 Nov 2020 19:11:26 -0600 |
From: Markus Armbruster <armbru@redhat.com>
Simple unions are simpler than flat unions in the schema, but more
complicated in C and on the QMP wire: there's extra indirection in C
and extra nesting on the wire, both pointless. They should be avoided
in new code.
GuestDeviceId was recently added for guest-get-devices. Convert it to
a flat union.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Michael Roth <michael.roth@amd.com>
---
qga/commands-win32.c | 9 ++++-----
qga/qapi-schema.json | 8 ++++++++
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 1efe3ba076..0c33d48aaa 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -2400,16 +2400,15 @@ GuestDeviceInfoList *qmp_guest_get_devices(Error **errp)
}
skip = false;
- id = g_new0(GuestDeviceIdPCI, 1);
vendor_id = g_match_info_fetch(match_info, 1);
device_id = g_match_info_fetch(match_info, 2);
- id->vendor_id = g_ascii_strtoull(vendor_id, NULL, 16);
- id->device_id = g_ascii_strtoull(device_id, NULL, 16);
device->id = g_new0(GuestDeviceId, 1);
device->has_id = true;
- device->id->type = GUEST_DEVICE_ID_KIND_PCI;
- device->id->u.pci.data = id;
+ device->id->type = GUEST_DEVICE_TYPE_PCI;
+ id = &device->id->u.pci;
+ id->vendor_id = g_ascii_strtoull(vendor_id, NULL, 16);
+ id->device_id = g_ascii_strtoull(device_id, NULL, 16);
g_match_info_free(match_info);
break;
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index c7bfb8bf6a..fe10631e4c 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -1256,6 +1256,12 @@
{ 'command': 'guest-get-osinfo',
'returns': 'GuestOSInfo' }
+##
+# @GuestDeviceType:
+##
+{ 'enum': 'GuestDeviceType',
+ 'data': [ 'pci' ] }
+
##
# @GuestDeviceIdPCI:
#
@@ -1276,6 +1282,8 @@
# Since: 5.2
##
{ 'union': 'GuestDeviceId',
+ 'base': { 'type': 'GuestDeviceType' },
+ 'discriminator': 'type',
'data': { 'pci': 'GuestDeviceIdPCI' } }
##
--
2.25.1
- [PULL v2 00/12] qemu-ga patch queue for soft-freeze, Michael Roth, 2020/11/02
- [PULL v2 10/12] qga: add *reset argument to ssh-add-authorized-keys, Michael Roth, 2020/11/02
- [PULL v2 11/12] meson: minor simplification, Michael Roth, 2020/11/02
- [PULL v2 12/12] qga: add ssh-get-authorized-keys, Michael Roth, 2020/11/02
- [PULL v2 01/12] qga: Rename guest-get-devices return member 'address' to 'id', Michael Roth, 2020/11/02
- [PULL v2 02/12] qga: Use common time encoding for guest-get-devices 'driver-date', Michael Roth, 2020/11/02
- [PULL v2 03/12] qga-win: Fix guest-get-devices error API violations, Michael Roth, 2020/11/02
- [PULL v2 04/12] qga: Flatten simple union GuestDeviceId,
Michael Roth <=
- [PULL v2 05/12] qga: add command guest-get-disks, Michael Roth, 2020/11/02
- [PULL v2 06/12] qga: add implementation of guest-get-disks for Linux, Michael Roth, 2020/11/02
- [PULL v2 07/12] qga: add implementation of guest-get-disks for Windows, Michael Roth, 2020/11/02
- [PULL v2 08/12] glib-compat: add g_unix_get_passwd_entry_qemu(), Michael Roth, 2020/11/02
- [PULL v2 09/12] qga: add ssh-{add,remove}-authorized-keys, Michael Roth, 2020/11/02
- Re: [PULL v2 00/12] qemu-ga patch queue for soft-freeze, no-reply, 2020/11/02
- Re: [PULL v2 00/12] qemu-ga patch queue for soft-freeze, Michael Roth, 2020/11/02