[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.2 v2] hw/mips: Remove the 'r4k' machine
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH-for-5.2 v2] hw/mips: Remove the 'r4k' machine |
Date: |
Mon, 2 Nov 2020 21:07:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 11/2/20 7:50 PM, Philippe Mathieu-Daudé wrote:
> We deprecated the support for the 'r4k' machine for the 5.0 release
> (commit d32dc61421), which means that our deprecation policy allows
> us to drop it in release 5.2. Remove the code.
>
> To repeat the rationale from the deprecation note:
> - this virtual machine has no specification
> - the Linux kernel dropped support for it 10 years ago
>
> Users are recommended to use the Malta board instead.
>
> Acked-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2: Fixed Header underline length (Richard)
> ---
> docs/system/deprecated.rst | 4 +-
> .../devices/mips-softmmu-common.mak | 1 -
> hw/mips/r4k.c | 318 ------------------
> MAINTAINERS | 6 -
> hw/mips/Kconfig | 13 -
> hw/mips/meson.build | 1 -
> 6 files changed, 2 insertions(+), 341 deletions(-)
> delete mode 100644 hw/mips/r4k.c
>
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 0ebce37a191..2a16078a09b 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -327,8 +327,8 @@ The 'scsi-disk' device is deprecated. Users should use
> 'scsi-hd' or
> System emulator machines
> ------------------------
>
> -mips ``r4k`` platform (since 5.0)
> -'''''''''''''''''''''''''''''''''
> +mips ``r4k`` platform (removed in 5.2)
> +''''''''''''''''''''''''''''''''''''''
>
> This machine type is very old and unmaintained. Users should use the
> ``malta``
> machine type instead.
This is incorrect, I have to move it from "Deprecated features"
to "Recently removed features" section.