[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/12] tools/virtiofsd: Check vu_init() return value (CID 1435958)
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 04/12] tools/virtiofsd: Check vu_init() return value (CID 1435958) |
Date: |
Mon, 2 Nov 2020 19:56:49 +0000 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Since commit 6f5fd837889, vu_init() can fail if malloc() returns NULL.
This fixes the following Coverity warning:
CID 1435958 (#1 of 1): Unchecked return value (CHECKED_RETURN)
Fixes: 6f5fd837889 ("libvhost-user: support many virtqueues")
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201102092339.2034297-1-philmd@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
tools/virtiofsd/fuse_virtio.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
index 324936948d..83ba07c6cd 100644
--- a/tools/virtiofsd/fuse_virtio.c
+++ b/tools/virtiofsd/fuse_virtio.c
@@ -1013,8 +1013,11 @@ int virtio_session_mount(struct fuse_session *se)
se->vu_socketfd = data_sock;
se->virtio_dev->se = se;
pthread_rwlock_init(&se->virtio_dev->vu_dispatch_rwlock, NULL);
- vu_init(&se->virtio_dev->dev, 2, se->vu_socketfd, fv_panic, NULL,
- fv_set_watch, fv_remove_watch, &fv_iface);
+ if (!vu_init(&se->virtio_dev->dev, 2, se->vu_socketfd, fv_panic, NULL,
+ fv_set_watch, fv_remove_watch, &fv_iface)) {
+ fuse_log(FUSE_LOG_ERR, "%s: vu_init failed\n", __func__);
+ return -1;
+ }
return 0;
}
--
2.28.0
- [PULL 00/12] migration queue, Dr. David Alan Gilbert (git), 2020/11/02
- [PULL 02/12] migration: Postpone the kick of the fault thread after recover, Dr. David Alan Gilbert (git), 2020/11/02
- [PULL 03/12] virtiofsd: Seccomp: Add 'send' for syslog, Dr. David Alan Gilbert (git), 2020/11/02
- [PULL 01/12] migration: Unify reset of last_rb on destination node when recover, Dr. David Alan Gilbert (git), 2020/11/02
- [PULL 05/12] virtiofsd: Fix the help message of posix lock, Dr. David Alan Gilbert (git), 2020/11/02
- [PULL 04/12] tools/virtiofsd: Check vu_init() return value (CID 1435958),
Dr. David Alan Gilbert (git) <=
- [PULL 06/12] virtiofsd: Check FUSE_SUBMOUNTS, Dr. David Alan Gilbert (git), 2020/11/02
- [PULL 07/12] virtiofsd: Add attr_flags to fuse_entry_param, Dr. David Alan Gilbert (git), 2020/11/02
- [PULL 08/12] meson.build: Check for statx(), Dr. David Alan Gilbert (git), 2020/11/02
- [PULL 09/12] virtiofsd: Add mount ID to the lo_inode key, Dr. David Alan Gilbert (git), 2020/11/02
- [PULL 10/12] virtiofsd: Announce sub-mount points, Dr. David Alan Gilbert (git), 2020/11/02
- [PULL 11/12] tests/acceptance/boot_linux: Accept SSH pubkey, Dr. David Alan Gilbert (git), 2020/11/02
- [PULL 12/12] tests/acceptance: Add virtiofs_submounts.py, Dr. David Alan Gilbert (git), 2020/11/02
- Re: [PULL 00/12] migration queue, Peter Maydell, 2020/11/03