[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] docs: show stdout/stderr when meson fails build test
From: |
Peter Maydell |
Subject: |
Re: [PATCH 3/4] docs: show stdout/stderr when meson fails build test |
Date: |
Mon, 2 Nov 2020 13:48:00 +0000 |
On Mon, 2 Nov 2020 at 13:09, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> It is hard to diagnose why Sphinx fails in a CI environment, as we
> discard the stdout/err and just print a generic error message.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This kind of detailed-diagnostics should go into whatever
meson's equivalent of config.log is. There's an argument
for printing it if the user asked for --enable-docs specifically,
but if we're doing the usual "see if it works, use it if it does"
logic then we shouldn't be printing diagnostic logging from
Sphinx (which can be pretty ugly and longwinded) in the middle
of the meson output, IMHO.
thanks
-- PMM
- [PATCH 0/4] Publish docs as GitLab Pages, Daniel P . Berrangé, 2020/11/02
- [PATCH 3/4] docs: show stdout/stderr when meson fails build test, Daniel P . Berrangé, 2020/11/02
- Re: [PATCH 3/4] docs: show stdout/stderr when meson fails build test,
Peter Maydell <=
- [PATCH 4/4] docs: add "page source" link to sphinx documentation, Daniel P . Berrangé, 2020/11/02
- Re: [PATCH 0/4] Publish docs as GitLab Pages, Philippe Mathieu-Daudé, 2020/11/02
- Re: [PATCH 0/4] Publish docs as GitLab Pages, Thomas Huth, 2020/11/09