[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v3 05/17] tests/9pfs: Factor out do_version() helper
From: |
Christian Schoenebeck |
Subject: |
[PULL v3 05/17] tests/9pfs: Factor out do_version() helper |
Date: |
Tue, 20 Oct 2020 18:09:14 +0200 |
From: Greg Kurz <groug@kaod.org>
fs_version() is a top level test function. Factor out the reusable
code to a separate helper instead of hijacking it in other tests.
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <160321015403.266767.4533967728943968456.stgit@bahia.lan>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
---
tests/qtest/virtio-9p-test.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
index 6401d4f564..92d12f5e02 100644
--- a/tests/qtest/virtio-9p-test.c
+++ b/tests/qtest/virtio-9p-test.c
@@ -567,10 +567,8 @@ static void v9fs_rflush(P9Req *req)
v9fs_req_free(req);
}
-static void fs_version(void *obj, void *data, QGuestAllocator *t_alloc)
+static void do_version(QVirtio9P *v9p)
{
- QVirtio9P *v9p = obj;
- alloc = t_alloc;
const char *version = "9P2000.L";
uint16_t server_len;
char *server_version;
@@ -585,13 +583,19 @@ static void fs_version(void *obj, void *data,
QGuestAllocator *t_alloc)
g_free(server_version);
}
+static void fs_version(void *obj, void *data, QGuestAllocator *t_alloc)
+{
+ alloc = t_alloc;
+ do_version(obj);
+}
+
static void fs_attach(void *obj, void *data, QGuestAllocator *t_alloc)
{
QVirtio9P *v9p = obj;
alloc = t_alloc;
P9Req *req;
- fs_version(v9p, NULL, t_alloc);
+ do_version(v9p);
req = v9fs_tattach(v9p, 0, getuid(), 0);
v9fs_req_wait_for_reply(req, NULL);
v9fs_rattach(req, NULL);
@@ -831,7 +835,7 @@ static void fs_walk_dotdot(void *obj, void *data,
QGuestAllocator *t_alloc)
v9fs_qid root_qid, *wqid;
P9Req *req;
- fs_version(v9p, NULL, t_alloc);
+ do_version(v9p);
req = v9fs_tattach(v9p, 0, getuid(), 0);
v9fs_req_wait_for_reply(req, NULL);
v9fs_rattach(req, &root_qid);
--
2.20.1
- [PULL v3 00/17] 9p queue (previous 2020-10-30), Christian Schoenebeck, 2020/11/02
- [PULL v3 01/17] tests/9pfs: make create/remove test dir public, Christian Schoenebeck, 2020/11/02
- [PULL v3 02/17] tests/9pfs: fix test dir for parallel tests, Christian Schoenebeck, 2020/11/02
- [PULL v3 03/17] tests/9pfs: fix coverity error in create_local_test_dir(), Christian Schoenebeck, 2020/11/02
- [PULL v3 04/17] tests/9pfs: Force removing of local 9pfs test directory, Christian Schoenebeck, 2020/11/02
- [PULL v3 05/17] tests/9pfs: Factor out do_version() helper,
Christian Schoenebeck <=
- [PULL v3 06/17] tests/9pfs: Set alloc in fs_create_dir(), Christian Schoenebeck, 2020/11/02
- [PULL v3 07/17] tests/9pfs: Factor out do_attach() helper, Christian Schoenebeck, 2020/11/02
- [PULL v3 08/17] tests/9pfs: Turn fs_readdir_split() into a helper, Christian Schoenebeck, 2020/11/02
- [PULL v3 09/17] tests/9pfs: Turn fs_mkdir() into a helper, Christian Schoenebeck, 2020/11/02
- [PULL v3 10/17] tests/9pfs: simplify do_mkdir(), Christian Schoenebeck, 2020/11/02
- [PULL v3 11/17] tests/9pfs: add local Tunlinkat directory test, Christian Schoenebeck, 2020/11/02
- [PULL v3 12/17] tests/9pfs: add local Tlcreate test, Christian Schoenebeck, 2020/11/02
- [PULL v3 13/17] tests/9pfs: add local Tunlinkat file test, Christian Schoenebeck, 2020/11/02
- [PULL v3 14/17] tests/9pfs: add local Tsymlink test, Christian Schoenebeck, 2020/11/02
- [PULL v3 15/17] tests/9pfs: add local Tunlinkat symlink test, Christian Schoenebeck, 2020/11/02