[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 10/11] sockets: Bypass "replace empty @path" for abstract unix
From: |
Markus Armbruster |
Subject: |
[PATCH v2 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets |
Date: |
Mon, 2 Nov 2020 10:44:21 +0100 |
unix_listen_saddr() replaces empty @path by unique value. It obtains
the value by creating and deleting a unique temporary file with
mkstemp(). This is racy, as the comment explains. It's also entirely
undocumented as far as I can tell. Goes back to commit d247d25f18
"sockets: helper functions for qemu (Gerd Hoffman)", v0.10.0.
Since abstract socket addresses have no connection with filesystem
pathnames, making them up with mkstemp() seems inappropriate. Bypass
the replacement of empty @path.
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
util/qemu-sockets.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index a578c434c2..671717499f 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -877,7 +877,7 @@ static int unix_listen_saddr(UnixSocketAddress *saddr,
return -1;
}
- if (saddr->path && saddr->path[0]) {
+ if (saddr->path[0] || saddr->abstract) {
path = saddr->path;
} else {
const char *tmpdir = getenv("TMPDIR");
--
2.26.2
- [PATCH v2 00/11] sockets: Attempt to drain the abstract socket swamp, Markus Armbruster, 2020/11/02
- [PATCH v2 02/11] test-util-sockets: Correct to set has_abstract, has_tight, Markus Armbruster, 2020/11/02
- [PATCH v2 06/11] test-util-sockets: Test the complete abstract socket matrix, Markus Armbruster, 2020/11/02
- [PATCH v2 01/11] test-util-sockets: Plug file descriptor leak, Markus Armbruster, 2020/11/02
- [PATCH v2 08/11] sockets: Fix socket_sockaddr_to_address_unix() for abstract sockets, Markus Armbruster, 2020/11/02
- [PATCH v2 03/11] test-util-sockets: Clean up SocketAddress construction, Markus Armbruster, 2020/11/02
- [PATCH v2 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets,
Markus Armbruster <=
- [PATCH v2 04/11] test-util-sockets: Factor out test_socket_unix_abstract_one(), Markus Armbruster, 2020/11/02
- [PATCH v2 07/11] sockets: Fix default of UnixSocketAddress member @tight, Markus Armbruster, 2020/11/02
- [PATCH v2 05/11] test-util-sockets: Synchronize properly, don't sleep(1), Markus Armbruster, 2020/11/02
- [PATCH v2 09/11] char-socket: Fix qemu_chr_socket_address() for abstract sockets, Markus Armbruster, 2020/11/02
[PATCH v2 11/11] sockets: Make abstract UnixSocketAddress depend on CONFIG_LINUX, Markus Armbruster, 2020/11/02