Re: [PATCH 09/36] qdev: Make qdev_get_prop

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg

From:	Marc-André Lureau
Subject:	Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg
Date:	Fri, 30 Oct 2020 11:34:09 +0400

On Fri, Oct 30, 2020 at 11:29 AM Marc-André Lureau <marcandre.lureau@gmail.com> wrote:

On Fri, Oct 30, 2020 at 2:07 AM Eduardo Habkost <ehabkost@redhat.com> wrote:
Make the code more generic and not specific to TYPE_DEVICE.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Nice cleanup!, but fails to build atm

../hw/block/xen-block.c:403:9: error: ‘dev’ undeclared (first use in this function); did you mean ‘vdev’?
403 | if (dev->realized) {

That seems to be the only issue though, so with that fixed:

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Marc-André Lureau

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 07/36] qdev: Make PropertyInfo.print method get Object* argument, (continued)
- [PATCH 08/36] qdev: Make bit_prop_set() get Object* argument, Eduardo Habkost, 2020/10/29
  - Re: [PATCH 08/36] qdev: Make bit_prop_set() get Object* argument, Marc-André Lureau, 2020/10/30
- [PATCH 05/36] sparc: Check dev->realized at sparc_set_nwindows(), Eduardo Habkost, 2020/10/29
  - Re: [PATCH 05/36] sparc: Check dev->realized at sparc_set_nwindows(), Marc-André Lureau, 2020/10/30
- [PATCH 10/36] qdev: Make qdev_find_global_prop() get Object* argument, Eduardo Habkost, 2020/10/29
  - Re: [PATCH 10/36] qdev: Make qdev_find_global_prop() get Object* argument, Marc-André Lureau, 2020/10/30
- [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg, Eduardo Habkost, 2020/10/29
  - Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg, Stefan Berger, 2020/10/29
  - Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg, Marc-André Lureau, 2020/10/30
    - Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg, Marc-André Lureau <=
    - --enable-xen on gitlab CI? (was Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg), Eduardo Habkost, 2020/10/30
    - Re: --enable-xen on gitlab CI? (was Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg), Paolo Bonzini, 2020/10/30
    - Re: --enable-xen on gitlab CI? (was Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg), Thomas Huth, 2020/10/31
- [PATCH 11/36] qdev: Make check_prop_still_unset() get Object* argument, Eduardo Habkost, 2020/10/29
  - Re: [PATCH 11/36] qdev: Make check_prop_still_unset() get Object* argument, Marc-André Lureau, 2020/10/30
- [PATCH 13/36] qdev: Wrap getters and setters in separate helpers, Eduardo Habkost, 2020/10/29
  - Re: [PATCH 13/36] qdev: Wrap getters and setters in separate helpers, Marc-André Lureau, 2020/10/30
- [PATCH 12/36] qdev: Make error_set_from_qdev_prop_error() get Object* argument, Eduardo Habkost, 2020/10/29
  - Re: [PATCH 12/36] qdev: Make error_set_from_qdev_prop_error() get Object* argument, Marc-André Lureau, 2020/10/30
    - Re: [PATCH 12/36] qdev: Make error_set_from_qdev_prop_error() get Object* argument, Eduardo Habkost, 2020/10/30

Prev by Date: Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg
Next by Date: Re: [PATCH 01/36] cs4231: Get rid of empty property array
Previous by thread: Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg
Next by thread: --enable-xen on gitlab CI? (was Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg)
Index(es):
- Date
- Thread