[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directo
From: |
Keith Packard |
Subject: |
Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories |
Date: |
Wed, 28 Oct 2020 08:37:55 -0700 |
Alex Bennée <alex.bennee@linaro.org> writes:
> I don't think we want arm specific adds in the common code. I think what
> Peter was suggesting is a new config symbol that only ARM and RISC
> define, e.g something like:
>
> specific_ss.add(when: 'CONFIG_ARM_STYLE_SEMIHOSTING',
> if_true: files ('common-semi.c'))
>
> or some other suitably descriptive symbol. Otherwise you have to keep
> adding an foo_ss.add line for each architecture that wants it.
Sure, that will also work, just a few lines of additional config file
stuff.
--
-keith
signature.asc
Description: PGP signature
[PATCH 2/4] semihosting: Change common-semi API to be architecture-independent, Keith Packard, 2020/10/26
[PATCH 3/4] semihosting: Change internal common-semi interfaces to use CPUState *, Keith Packard, 2020/10/26
[PATCH 4/4] riscv: Add semihosting support [v10], Keith Packard, 2020/10/26
Re: [PATCH 0/4] riscv: Add semihosting support [v10], no-reply, 2020/10/26