[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-web PATCH v2 11/16] Bring contribution links out of the footer
From: |
Kashyap Chamarthy |
Subject: |
Re: [qemu-web PATCH v2 11/16] Bring contribution links out of the footer into the home page |
Date: |
Tue, 27 Oct 2020 16:02:49 +0100 |
On Tue, Oct 27, 2020 at 01:20:10PM +0000, Daniel P. Berrangé wrote:
> The selection of contribution links are important information to present
> to visitors to the site. They are best placed in a prominent position on
> the home page rather than in the footer
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Yeah, I personally didn't realize all the useful Contribute-related
links that were only one scroll away in the old page vs. having it front
and center in your new rendering:
https://berrange.gitlab.io/qemu-web/
Definitely useful.
FWIW:
Reviewed-by: Kashyap Chamarthy <kchamart@redhat.com>
> ---
> _includes/footer.html | 7 -------
> index.html | 8 ++++++++
> 2 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/_includes/footer.html b/_includes/footer.html
> index 411ff55..07f7866 100644
> --- a/_includes/footer.html
> +++ b/_includes/footer.html
> @@ -5,13 +5,6 @@
> <li><a href="{{ relative_root
> }}/download">Download</a></li>
> <li><a href="http://qemu-advent-calendar.org">QEMU
> advent calendar</a></li>
> </ul>
> - <ul class="style">
> - <li><a href="{{ relative_root
> }}/contribute">Contribute</a></li>
> - <li><a href="{{ relative_root
> }}/contribute/report-a-bug">Reporting a bug</a></li>
> - <li><a
> href="https://wiki.qemu.org/Documentation/GettingStartedDevelopers">New
> contributors</a></li>
> - <li><a
> href="https://wiki.qemu.org/Contribute/SubmitAPatch">Submitting a
> patch</a></li>
> - <li><a
> href="https://wiki.qemu.org/Contribute/FAQ">Contributor FAQ</a></li>
> - </ul>
> <ul class="style">
> <li><a href="{{ relative_root
> }}/documentation">Documentation</a></li>
> <li><a href="https://www.qemu.org/docs/master/">Main
> docs</a></li>
> diff --git a/index.html b/index.html
> index d057a87..be1d210 100644
> --- a/index.html
> +++ b/index.html
> @@ -27,6 +27,14 @@ bxslider: True
> <span><a href="{{ relative_root }}/download">Other
> releases</a></span>
> </li>
> {% endfor %}
> +
> + <li><strong>Contribute</strong>
> + <span><a href="{{ relative_root
> }}/contribute">Overview</a></span>
> + <span><a href="{{ relative_root
> }}/contribute/report-a-bug">Reporting a bug</a></span>
> + <span><a
> href="https://wiki.qemu.org/Documentation/GettingStartedDevelopers">New
> contributors</a></span>
> + <span><a
> href="https://wiki.qemu.org/Contribute/SubmitAPatch">Submitting a
> patch</a></span>
> + <span><a
> href="https://wiki.qemu.org/Contribute/FAQ">Contributor FAQ</a></span>
> + </li>
> </ul>
> </div>
> </div>
> --
> 2.26.2
>
>
--
/kashyap
- [qemu-web PATCH v2 04/16] Make page header nav narrower, (continued)
- [qemu-web PATCH v2 04/16] Make page header nav narrower, Daniel P . Berrangé, 2020/10/27
- [qemu-web PATCH v2 03/16] make all links be relative to the root, Daniel P . Berrangé, 2020/10/27
- [qemu-web PATCH v2 01/16] Convert files to UNIX line endings, Daniel P . Berrangé, 2020/10/27
- [qemu-web PATCH v2 06/16] Rework display of screenshots to use a carousel slider, Daniel P . Berrangé, 2020/10/27
- [qemu-web PATCH v2 05/16] Introduce support for "bxslider" jquery add on, Daniel P . Berrangé, 2020/10/27
- [qemu-web PATCH v2 07/16] Compress the two front page headings into one, Daniel P . Berrangé, 2020/10/27
- [qemu-web PATCH v2 08/16] Simplify copyright and integrate into footer, Daniel P . Berrangé, 2020/10/27
- [qemu-web PATCH v2 09/16] Put a full SFC membership blurb in footer of every page, Daniel P . Berrangé, 2020/10/27
- [qemu-web PATCH v2 10/16] Use two column layout to display screenshots and releases, Daniel P . Berrangé, 2020/10/27
- [qemu-web PATCH v2 11/16] Bring contribution links out of the footer into the home page, Daniel P . Berrangé, 2020/10/27
- Re: [qemu-web PATCH v2 11/16] Bring contribution links out of the footer into the home page,
Kashyap Chamarthy <=
- [qemu-web PATCH v2 12/16] Add recent blog posts to the front page featured content, Daniel P . Berrangé, 2020/10/27
- [qemu-web PATCH v2 13/16] Move wiki link from footer into the header navbar, Daniel P . Berrangé, 2020/10/27
- [qemu-web PATCH v2 14/16] Simplify and restructure the page footer, Daniel P . Berrangé, 2020/10/27
- [qemu-web PATCH v2 15/16] Add link to "page source" for all pages, Daniel P . Berrangé, 2020/10/27
- [qemu-web PATCH v2 16/16] Add a CONTRIBUTING.md file as guidance for contributors, Daniel P . Berrangé, 2020/10/27