[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/8] hw/timer/sh_timer: Remove superfluous "break" statements
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 4/8] hw/timer/sh_timer: Remove superfluous "break" statements |
Date: |
Tue, 27 Oct 2020 00:29:31 +0100 |
From: Thomas Huth <thuth@redhat.com>
hw_error() is marked as QEMU_NORETURN, so the "break" statements
after this function are just dead code.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201020153935.54315-4-thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/timer/sh_timer.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c
index 934daaa7dcc..58af1a1edbd 100644
--- a/hw/timer/sh_timer.c
+++ b/hw/timer/sh_timer.c
@@ -125,7 +125,6 @@ static void sh_timer_write(void *opaque, hwaddr offset,
/* fallthrough */
default:
hw_error("sh_timer_write: Reserved TPSC value\n");
- break;
}
switch ((value & TIMER_TCR_CKEG) >> 3) {
case 0:
@@ -139,7 +138,6 @@ static void sh_timer_write(void *opaque, hwaddr offset,
/* fallthrough */
default:
hw_error("sh_timer_write: Reserved CKEG value\n");
- break;
}
switch ((value & TIMER_TCR_ICPE) >> 6) {
case 0:
@@ -152,7 +150,6 @@ static void sh_timer_write(void *opaque, hwaddr offset,
/* fallthrough */
default:
hw_error("sh_timer_write: Reserved ICPE value\n");
- break;
}
if ((value & TIMER_TCR_UNF) == 0) {
s->int_level = 0;
--
2.26.2
- [PULL 0/8] Renesas patches for 2020-10-27, Philippe Mathieu-Daudé, 2020/10/26
- [PULL 1/8] elf: Add EM_RX definition, Philippe Mathieu-Daudé, 2020/10/26
- [PULL 3/8] hw/timer/sh_timer: Silence warnings about missing fallthrough statements, Philippe Mathieu-Daudé, 2020/10/26
- [PULL 2/8] hw/timer/sh_timer: Coding style clean-up, Philippe Mathieu-Daudé, 2020/10/26
- [PULL 4/8] hw/timer/sh_timer: Remove superfluous "break" statements,
Philippe Mathieu-Daudé <=
- [PULL 5/8] target/sh4: Update coding style to make checkpatch.pl happy, Philippe Mathieu-Daudé, 2020/10/26
- [PULL 6/8] target/sh4: fix some comment spelling errors, Philippe Mathieu-Daudé, 2020/10/26
- [PULL 7/8] target/rx: Fix some comment spelling errors, Philippe Mathieu-Daudé, 2020/10/26
- [PULL 8/8] target/rx: Fix Lesser GPL version number, Philippe Mathieu-Daudé, 2020/10/26
- Re: [PULL 0/8] Renesas patches for 2020-10-27, Peter Maydell, 2020/10/28