qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/15] lm32: remove bios_name


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 06/15] lm32: remove bios_name
Date: Mon, 26 Oct 2020 19:12:17 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 10/26/20 3:30 PM, Paolo Bonzini wrote:
Cc: Michael Walle <michael@walle.cc>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
  hw/lm32/milkymist.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c
index 9f8fe9fef1..c5d3d77a2b 100644
--- a/hw/lm32/milkymist.c
+++ b/hw/lm32/milkymist.c
@@ -108,6 +108,7 @@ static void
  milkymist_init(MachineState *machine)
  {
      MachineClass *mc = MACHINE_GET_CLASS(machine);
+    const char *bios_name = machine->firmware ? BIOS_FILENAME:

Does that build?

      const char *kernel_filename = machine->kernel_filename;
      const char *kernel_cmdline = machine->kernel_cmdline;
      const char *initrd_filename = machine->initrd_filename;
@@ -162,9 +163,6 @@ milkymist_init(MachineState *machine)
      }
/* load bios rom */
-    if (bios_name == NULL) {
-        bios_name = BIOS_FILENAME;
-    }
      bios_filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name);
if (bios_filename) {





reply via email to

[Prev in Thread] Current Thread [Next in Thread]