[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level |
Date: |
Mon, 26 Oct 2020 17:13:40 +0000 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
* Misono Tomohiro (misono.tomohiro@jp.fujitsu.com) wrote:
> Just noticed that although help message says default log level is INFO,
> it is actually 0 (EMRGE) and no mesage will be shown when error occurs.
> It's better to follow help message.
>
> Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Queued
> ---
> tools/virtiofsd/passthrough_ll.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tools/virtiofsd/passthrough_ll.c
> b/tools/virtiofsd/passthrough_ll.c
> index 0b229ebd57..4ff9f1b688 100644
> --- a/tools/virtiofsd/passthrough_ll.c
> +++ b/tools/virtiofsd/passthrough_ll.c
> @@ -2888,12 +2888,11 @@ int main(int argc, char *argv[])
> goto err_out1;
> }
>
> - /*
> - * log_level is 0 if not configured via cmd options (0 is LOG_EMERG,
> - * and we don't use this log level).
> - */
> if (opts.log_level != 0) {
> current_log_level = opts.log_level;
> + } else {
> + /* default log level is INFO */
> + current_log_level = FUSE_LOG_INFO;
> }
> lo.debug = opts.debug;
> if (lo.debug) {
> --
> 2.25.4
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK