[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/5] hw/sd/sdcard: Constify sd_crc*()'s message argument
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 3/5] hw/sd/sdcard: Constify sd_crc*()'s message argument |
Date: |
Mon, 26 Oct 2020 12:03:13 +0100 |
CRC functions don't modify the buffer argument,
make it const.
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200630133912.9428-14-f4bug@amsat.org>
---
hw/sd/sd.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 5510a64401b..aa6059d2ad6 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -254,11 +254,11 @@ static const int sd_cmd_class[SDMMC_CMD_MAX] = {
7, 7, 10, 7, 9, 9, 9, 8, 8, 10, 8, 8, 8, 8, 8, 8,
};
-static uint8_t sd_crc7(void *message, size_t width)
+static uint8_t sd_crc7(const void *message, size_t width)
{
int i, bit;
uint8_t shift_reg = 0x00;
- uint8_t *msg = (uint8_t *) message;
+ const uint8_t *msg = (const uint8_t *)message;
for (i = 0; i < width; i ++, msg ++)
for (bit = 7; bit >= 0; bit --) {
@@ -270,11 +270,11 @@ static uint8_t sd_crc7(void *message, size_t width)
return shift_reg;
}
-static uint16_t sd_crc16(void *message, size_t width)
+static uint16_t sd_crc16(const void *message, size_t width)
{
int i, bit;
uint16_t shift_reg = 0x0000;
- uint16_t *msg = (uint16_t *) message;
+ const uint16_t *msg = (const uint16_t *)message;
width <<= 1;
for (i = 0; i < width; i ++, msg ++)
--
2.26.2
- [PULL 0/5] SD/MMC patches for 2020-10-26, Philippe Mathieu-Daudé, 2020/10/26
- [PULL 1/5] hw/sd/sdcard: Update the SDState documentation, Philippe Mathieu-Daudé, 2020/10/26
- [PULL 2/5] hw/sd/sdcard: Simplify cmd_valid_while_locked(), Philippe Mathieu-Daudé, 2020/10/26
- [PULL 3/5] hw/sd/sdcard: Constify sd_crc*()'s message argument,
Philippe Mathieu-Daudé <=
- [PULL 5/5] hw/sd/sdcard: Zero out function selection fields before being populated, Philippe Mathieu-Daudé, 2020/10/26
- [PULL 4/5] hw/sd/sdcard: Make iolen unsigned, Philippe Mathieu-Daudé, 2020/10/26
- Re: [PULL 0/5] SD/MMC patches for 2020-10-26, Peter Maydell, 2020/10/26