Re: [PATCH v4 05/12] tests/qtest/qos-test: dump qos graph if verbose

[Thomas Huth]

On 08/10/2020 20.34, Christian Schoenebeck wrote:
> If qtests were run in verbose mode (i.e. if --verbose CL argument was
> provided) then dump the generated qos graph (all nodes and edges,
> along with their current individual availability status) to stdout.
> 
> See API doc comment on function qos_dump_graph() for details.
> 
> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> ---
>  tests/qtest/qos-test.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c
> index 8fdf87b183..d98ef78613 100644
> --- a/tests/qtest/qos-test.c
> +++ b/tests/qtest/qos-test.c
> @@ -322,6 +322,9 @@ int main(int argc, char **argv)
>      qos_set_machines_devices_available();
>  
>      qos_graph_foreach_test_path(walk_path);
> +    if (g_test_verbose()) {
> +        qos_dump_graph();
> +    }
>      g_test_run();
>      qtest_end();
>      qos_graph_destroy();
> 

I'd squash this into the previous patch, so that it is clear there where the
function gets used.

 Thomas