Re: [PATCH v2 6/8] tests/9pfs: add local Tunlinkat symlink test

[Greg Kurz]

On Wed, 21 Oct 2020 14:36:23 +0200
Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:

> This test case uses a Tunlinkat request to remove a symlink using
> the 9pfs 'local' fs driver.
> 
> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> ---

Reviewed-by: Greg Kurz <groug@kaod.org>

>  tests/qtest/virtio-9p-test.c | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
> index 0c11417236..33cba24b18 100644
> --- a/tests/qtest/virtio-9p-test.c
> +++ b/tests/qtest/virtio-9p-test.c
> @@ -1295,6 +1295,32 @@ static void fs_symlink_file(void *obj, void *data, 
> QGuestAllocator *t_alloc)
>      g_free(real_file);
>  }
>  
> +static void fs_unlinkat_symlink(void *obj, void *data,
> +                                QGuestAllocator *t_alloc)
> +{
> +    QVirtio9P *v9p = obj;
> +    alloc = t_alloc;
> +    struct stat st;
> +    char *real_file = virtio_9p_test_path("06/real_file");
> +    char *symlink_file = virtio_9p_test_path("06/symlink_file");
> +
> +    do_attach(v9p);
> +    do_mkdir(v9p, "/", "06");
> +    do_lcreate(v9p, "06", "real_file");
> +    g_assert(stat(real_file, &st) == 0);
> +    g_assert((st.st_mode & S_IFMT) == S_IFREG);
> +
> +    do_symlink(v9p, "06", "symlink_file", "real_file");
> +    g_assert(stat(symlink_file, &st) == 0);
> +
> +    do_unlinkat(v9p, "06", "symlink_file", 0);
> +    /* symlink should be gone now */
> +    g_assert(stat(symlink_file, &st) != 0);
> +
> +    g_free(symlink_file);
> +    g_free(real_file);
> +}
> +
>  static void *assign_9p_local_driver(GString *cmd_line, void *arg)
>  {
>      virtio_9p_assign_local_driver(cmd_line, "security_model=mapped-xattr");
> @@ -1339,6 +1365,8 @@ static void register_virtio_9p_test(void)
>      qos_add_test("local/create_file", "virtio-9p", fs_create_file, &opts);
>      qos_add_test("local/unlinkat_file", "virtio-9p", fs_unlinkat_file, 
> &opts);
>      qos_add_test("local/symlink_file", "virtio-9p", fs_symlink_file, &opts);
> +    qos_add_test("local/unlinkat_symlink", "virtio-9p", fs_unlinkat_symlink,
> +                 &opts);
>  }
>  
>  libqos_init(register_virtio_9p_test);