[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qmp: fix aio_poll() assertion failure on Windows
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH] qmp: fix aio_poll() assertion failure on Windows |
Date: |
Wed, 21 Oct 2020 15:51:59 +0100 |
On Wed, Oct 21, 2020 at 08:40:33AM +0200, Volker Rümelin wrote:
> Commit 9ce44e2ce2 "qmp: Move dispatcher to a coroutine" modified
> aio_poll() in util/aio-posix.c to avoid an assertion failure. This
> change is missing in util/aio-win32.c.
>
> Apply the changes to util/aio-posix.c to util/aio-win32.c too.
> This fixes an assertion failure on Windows whenever QEMU exits.
>
> $ ./qemu-system-x86_64.exe -machine pc,accel=tcg -display gtk
> **
> ERROR:../qemu/util/aio-win32.c:337:aio_poll: assertion failed:
> (in_aio_context_home_thread(ctx))
> Bail out! ERROR:../qemu/util/aio-win32.c:337:aio_poll: assertion
> failed: (in_aio_context_home_thread(ctx))
>
> Fixes: 9ce44e2ce2 ("qmp: Move dispatcher to a coroutine")
> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
> ---
> util/aio-win32.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Thanks, applied to my block-next tree:
https://gitlab.com/stefanha/qemu/commits/block-next
Stefan
signature.asc
Description: PGP signature