[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pc: Implement -no-hpet as sugar for -machine hpet=off
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH] pc: Implement -no-hpet as sugar for -machine hpet=off |
Date: |
Wed, 21 Oct 2020 08:39:20 -0400 |
On Wed, Oct 21, 2020 at 09:32:59AM +0200, Paolo Bonzini wrote:
> On 21/10/20 00:01, Eduardo Habkost wrote:
> > + pcms->hpet_enabled = true;
>
> Should this be within #ifdef CONFIG_HPET? [...]
Oops, I wasn't aware of CONFIG_HPET, and hadn't noticed that
pc_basic_device_init() uses qdev_try_new(). I agree that not
failing if hpet=on is explicitly set and CONFIG_HPET=n is wrong.
Supporting a "require hpet to be on" use case would be a new
feature and out of scope of this work, though. I will just
rename the property to "allow-hpet". We can still implement a
OnOfAuto "hpet" property in the future, if we think it's useful.
> [...] Otherwise
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Thanks!
--
Eduardo