|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 1/4] qga: Rename guest-get-devices return member 'address' to 'id' |
Date: | Wed, 21 Oct 2020 09:34:35 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/21/20 9:15 AM, Markus Armbruster wrote:
Member 'address' is union GuestDeviceAddress with a single branch GuestDeviceAddressPCI, containing PCI vendor ID and device ID. This is not a PCI address. Type GuestPCIAddress is. Messed up in recent commit 2e4211cee4 "qga: add command guest-get-devices for reporting VirtIO devices".
Out of curiosity, how did you notice? Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Rename type GuestDeviceAddressPCI to GuestDeviceIdPCI, type GuestDeviceAddress to GuestDeviceId, and member 'address' to 'id'. Document the member properly while there. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- qga/qapi-schema.json | 17 +++++++++-------- qga/commands-win32.c | 16 ++++++++-------- 2 files changed, 17 insertions(+), 16 deletions(-)
[Prev in Thread] | Current Thread | [Next in Thread] |