Re: [PATCH 0/2] KVM: Introduce ioeventfd read support

[no-reply]

Patchew URL: 
20201020170056.433528-1-ameynarkhede03@gmail.com/">https://patchew.org/QEMU/20201020170056.433528-1-ameynarkhede03@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201020170056.433528-1-ameynarkhede03@gmail.com
Subject: [PATCH 0/2] KVM: Introduce ioeventfd read support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20201020163738.27700-1-alex.bennee@linaro.org -> 
patchew/20201020163738.27700-1-alex.bennee@linaro.org
 * [new tag]         patchew/20201020170056.433528-1-ameynarkhede03@gmail.com 
-> patchew/20201020170056.433528-1-ameynarkhede03@gmail.com
Switched to a new branch 'test'
eccca33 kvm: Add ioeventfd read test code
33b3de6 linux-headers: Add support for reads in ioeventfd

=== OUTPUT BEGIN ===
1/2 Checking commit 33b3de672219 (linux-headers: Add support for reads in 
ioeventfd)
2/2 Checking commit eccca33098c6 (kvm: Add ioeventfd read test code)
ERROR: code indent should never use tabs
#31: FILE: accel/kvm/kvm-all.c:1016:
+^I^I^I^I  uint64_t size, bool datamatch)$

ERROR: code indent should never use tabs
#33: FILE: accel/kvm/kvm-all.c:1018:
+^Iint ret;$

ERROR: code indent should never use tabs
#34: FILE: accel/kvm/kvm-all.c:1019:
+^Istruct kvm_ioeventfd ioevent = {$

WARNING: line over 80 characters
#35: FILE: accel/kvm/kvm-all.c:1020:
+               .datamatch = datamatch ? adjust_ioeventfd_endianness(val, size) 
: 0,

ERROR: code indent should never use tabs
#35: FILE: accel/kvm/kvm-all.c:1020:
+        ^I.datamatch = datamatch ? adjust_ioeventfd_endianness(val, size) : 0,$

ERROR: code indent should never use tabs
#36: FILE: accel/kvm/kvm-all.c:1021:
+^I^I.dataread = val,$

ERROR: code indent should never use tabs
#37: FILE: accel/kvm/kvm-all.c:1022:
+^I^I.addr = addr,$

ERROR: code indent should never use tabs
#38: FILE: accel/kvm/kvm-all.c:1023:
+^I^I.len = size,$

ERROR: code indent should never use tabs
#39: FILE: accel/kvm/kvm-all.c:1024:
+^I^I.flags = KVM_IOEVENTFD_FLAG_DATAREAD,$

ERROR: code indent should never use tabs
#40: FILE: accel/kvm/kvm-all.c:1025:
+^I^I.fd = fd,$

ERROR: code indent should never use tabs
#41: FILE: accel/kvm/kvm-all.c:1026:
+^I};$

ERROR: code indent should never use tabs
#43: FILE: accel/kvm/kvm-all.c:1028:
+^Iif (!kvm_enabled()) {$

ERROR: code indent should never use tabs
#44: FILE: accel/kvm/kvm-all.c:1029:
+^I^Ireturn -ENOSYS;$

ERROR: code indent should never use tabs
#45: FILE: accel/kvm/kvm-all.c:1030:
+^I}$

ERROR: code indent should never use tabs
#47: FILE: accel/kvm/kvm-all.c:1032:
+^Iif (datamatch) {$

ERROR: code indent should never use tabs
#49: FILE: accel/kvm/kvm-all.c:1034:
+^I}$

ERROR: code indent should never use tabs
#51: FILE: accel/kvm/kvm-all.c:1036:
+^Iret = kvm_vm_ioctl(kvm_state, KVM_IOEVENTFD, &ioevent);$

ERROR: code indent should never use tabs
#53: FILE: accel/kvm/kvm-all.c:1038:
+^Iif (ret < 0) {$

ERROR: code indent should never use tabs
#54: FILE: accel/kvm/kvm-all.c:1039:
+^I^Ireturn -errno;$

ERROR: code indent should never use tabs
#55: FILE: accel/kvm/kvm-all.c:1040:
+^I}$

ERROR: code indent should never use tabs
#57: FILE: accel/kvm/kvm-all.c:1042:
+^Ireturn 0;$

ERROR: code indent should never use tabs
#80: FILE: accel/kvm/kvm-all.c:2298:
+^Iprintf("Failed to initialize EventNotifier\n");$

ERROR: else should follow close brace '}'
#82: FILE: accel/kvm/kvm-all.c:2300:
+    }
+    else {

ERROR: braces {} are necessary for all arms of this statement
#87: FILE: accel/kvm/kvm-all.c:2305:
+        if (ret < 0)
[...]

total: 23 errors, 1 warnings, 79 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201020170056.433528-1-ameynarkhede03@gmail.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201020170056.433528-1-ameynarkhede03@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com