Re: [PATCH v2 5/9] tcg: add const hints for code pointers

[Joelle van Dyne]

Seems like I missed a few. Sorry about that. Will fix.

-j

On Mon, Oct 19, 2020 at 4:27 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 10/18/20 6:39 PM, Joelle van Dyne wrote:
> > From: osy <osy86@users.noreply.github.com>
> >
> > We will introduce mirror mapping for JIT segment with separate RX and RW
> > access. Adding 'const' hints will make it easier to identify read-only
> > accesses and allow us to easier catch bugs at compile time in the future.
> >
> > Signed-off-by: Joelle van Dyne <j@getutm.app>
> > ---
> >  include/tcg/tcg.h            |  8 ++++----
> >  tcg/tcg.c                    |  4 ++--
> >  tcg/aarch64/tcg-target.c.inc | 19 +++++++++++--------
> >  tcg/arm/tcg-target.c.inc     | 12 +++++++-----
> >  tcg/i386/tcg-target.c.inc    | 10 +++++-----
> >  tcg/mips/tcg-target.c.inc    | 33 +++++++++++++++++++--------------
> >  tcg/ppc/tcg-target.c.inc     | 21 +++++++++++++--------
> >  tcg/riscv/tcg-target.c.inc   | 11 ++++++-----
> >  tcg/s390/tcg-target.c.inc    |  9 +++++----
> >  tcg/sparc/tcg-target.c.inc   | 10 +++++-----
> >  tcg/tcg-ldst.c.inc           |  2 +-
> >  tcg/tci/tcg-target.c.inc     |  2 +-
> >  12 files changed, 79 insertions(+), 62 deletions(-)
>
> tcg/ppc/tcg-target.c.inc:2349:26: error: assignment discards ‘const’ qualifier
> from pointer target type [-Werror]
>      s->code_gen_epilogue = tb_ret_addr = s->code_ptr;
>
> How many of the targets did you build?
>
>
> r~