Re: [PATCH v5] sev: add sev-inject-launch-secret

[Tobin Feldman-Fitzthum]

On 2020-10-19 12:47, Eduardo Habkost wrote:
> On Mon, Oct 19, 2020 at 12:46:08PM -0400, Eduardo Habkost wrote:
> > On Thu, Oct 15, 2020 at 10:37:13AM -0400, tobin@linux.ibm.com wrote:
> > [...]
> > > diff --git a/target/i386/sev-stub.c b/target/i386/sev-stub.c
> > > index 88e3f39a1e..2d2ee54cc6 100644
> > > --- a/target/i386/sev-stub.c
> > > +++ b/target/i386/sev-stub.c
> > > @@ -49,3 +49,8 @@ SevCapability *sev_get_capabilities(Error **errp)
> > >      error_setg(errp, "SEV is not available in this QEMU");
> > >      return NULL;
> > >  }
> > > +int sev_inject_launch_secret(const char *hdr, const char *secret,
> > > +                             uint64_t gpa)
> > > +{
> > > +    return 1;
> > > +}
> >
> > This doesn't match the actual function prototype.  I had to apply the 
> > following
> > fixup:
> >
> > ---
> > diff --git a/target/i386/sev-stub.c b/target/i386/sev-stub.c
> > index 2d2ee54cc6..62a2587e7b 100644
> > --- a/target/i386/sev-stub.c
> > +++ b/target/i386/sev-stub.c
> > @@ -49,8 +49,10 @@ SevCapability *sev_get_capabilities(Error **errp)
> >      error_setg(errp, "SEV is not available in this QEMU");
> >      return NULL;
> >  }
> > +
> >  int sev_inject_launch_secret(const char *hdr, const char *secret,
> > -                             uint64_t gpa)
> > +                             uint64_t gpa, Error *errp)
>
> Oops. Fixing up the fixup:

Thanks Eduardo.

-Tobin
> ---
> diff --git a/target/i386/sev-stub.c b/target/i386/sev-stub.c
> index 62a2587e7b..e4e60d9a7d 100644
> --- a/target/i386/sev-stub.c
> +++ b/target/i386/sev-stub.c
> @@ -51,7 +51,7 @@ SevCapability *sev_get_capabilities(Error **errp)
>  }
>
>  int sev_inject_launch_secret(const char *hdr, const char *secret,
> -                             uint64_t gpa, Error *errp)
> +                             uint64_t gpa, Error **errp)
>  {
>      error_setg(errp, "SEV is not available in this QEMU");
>      return 1;