|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 4/6] sun4u: use qdev instead of legacy m48t59_init() function |
Date: | Sun, 18 Oct 2020 09:15:36 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/17/20 10:13 PM, BALATON Zoltan via wrote:
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> --- hw/sparc64/sun4u.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index ad5ca2472a..a89ebed6f0 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -671,10 +671,12 @@ static void sun4uv_init(MemoryRegion *address_space_mem, pci_ide_create_devs(pci_dev);/* Map NVRAM into I/O (ebus) space */- nvram = m48t59_init(NULL, 0, 0, NVRAM_SIZE, 1968, 59); - s = SYS_BUS_DEVICE(nvram); + dev = qdev_new("sysbus-m48t59"); + s = SYS_BUS_DEVICE(dev); + sysbus_realize_and_unref(s, &error_fatal);
I'd use &error_abort here (so if that ever happens, it is easier to debug it), otherwise: Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
memory_region_add_subregion(pci_address_space_io(ebus), 0x2000, sysbus_mmio_get_region(s, 0)); + nvram = NVRAM(dev);initrd_size = 0;initrd_addr = 0;
[Prev in Thread] | Current Thread | [Next in Thread] |