[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/14] tests/test-char: Use a proper fallthrough comment
From: |
Laurent Vivier |
Subject: |
[PULL 04/14] tests/test-char: Use a proper fallthrough comment |
Date: |
Tue, 13 Oct 2020 13:50:42 +0200 |
From: Thomas Huth <thuth@redhat.com>
For being able to compile with -Werror=implicit-fallthrough we need
to use comments that the compiler recognizes. Use "fallthrough" instead
of "no break" here.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201002171343.283426-1-thuth@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
tests/test-char.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test-char.c b/tests/test-char.c
index d35cc839bc60..9196e566e9ba 100644
--- a/tests/test-char.c
+++ b/tests/test-char.c
@@ -70,7 +70,7 @@ static void fe_event(void *opaque, QEMUChrEvent event)
h->openclose_mismatch = true;
}
h->is_open = new_open_state;
- /* no break */
+ /* fallthrough */
default:
quit = true;
break;
--
2.26.2
- [PULL 00/14] Trivial branch for 5.2 patches, Laurent Vivier, 2020/10/13
- [PULL 02/14] target/i386/cpu: Update comment that mentions Texinfo, Laurent Vivier, 2020/10/13
- [PULL 04/14] tests/test-char: Use a proper fallthrough comment,
Laurent Vivier <=
- [PULL 03/14] hw/block/nvme: Simplify timestamp sum, Laurent Vivier, 2020/10/13
- [PULL 01/14] qemu-img-cmds.hx: Update comment that mentions Texinfo, Laurent Vivier, 2020/10/13
- [PULL 06/14] hw/acpi/piix4: Rename piix4_pm_add_propeties() to piix4_pm_add_properties(), Laurent Vivier, 2020/10/13
- [PULL 07/14] softmmu/memory: Log invalid memory accesses, Laurent Vivier, 2020/10/13
- [PULL 08/14] hw/pci: Fix typo in PCI hot-plug error message, Laurent Vivier, 2020/10/13
- [PULL 12/14] target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry, Laurent Vivier, 2020/10/13
- [PULL 09/14] block/blkdebug: fix memory leak, Laurent Vivier, 2020/10/13
- [PULL 10/14] hw/char/serial: remove duplicate .class_init in serial_mm_info, Laurent Vivier, 2020/10/13
- [PULL 11/14] goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN, Laurent Vivier, 2020/10/13
- [PULL 13/14] mingw: fix error __USE_MINGW_ANSI_STDIO redefined, Laurent Vivier, 2020/10/13