qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] python/qemu: strictly typed mypy conversion, pt3


From: John Snow
Subject: Re: [PATCH 0/3] python/qemu: strictly typed mypy conversion, pt3
Date: Mon, 12 Oct 2020 10:54:59 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 10/9/20 1:51 PM, John Snow wrote:
This is actually quite short; it's already fully typed. Attached are two
fixes for settimeout and error handling. There are actually more fixes
that need to be made here, because use of readline() in non-blocking
mode is actually undefined behavior, so a more thorough re-work of the
error classes used by this library must be put on hold pending a more
aggressive re-write.

That's a problem for later, so for now, call the initial conversion to
the statically typed subset of python done so we can move on to adding
the regression tests that will maintain this baseline for us.

John Snow (3):
   python: add mypy config
   python/qemu/qmp.py: re-raise OSError when encountered
   python/qemu/qmp.py: Fix settimeout operation

  python/mypy.ini    |  4 ++++
  python/qemu/qmp.py | 30 +++++++++++++++++++++---------
  2 files changed, 25 insertions(+), 9 deletions(-)
  create mode 100644 python/mypy.ini


Thanks -- tentatively staging to my Python branch. I intend to send a PR on Friday, so if there's more feedback, there's plenty of time.

https://gitlab.com/jsnow/qemu.git python
https://gitlab.com/jsnow/qemu/-/commits/python




reply via email to

[Prev in Thread] Current Thread [Next in Thread]