qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 00/36] qapi: static typing conversion, pt1


From: John Snow
Subject: Re: [PATCH v6 00/36] qapi: static typing conversion, pt1
Date: Mon, 12 Oct 2020 10:19:14 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 10/10/20 5:43 AM, Markus Armbruster wrote:
John Snow <jsnow@redhat.com> writes:

Hi, this series adds static type hints to the QAPI module.
This is part one!

Part 1: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt1
Everything: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt6

- Requires Python 3.6+
- Requires mypy 0.770 or newer (for type analysis only)
- Requires pylint 2.6.0 or newer (for lint checking only)

In general, this series tackles the cleanup of one individual QAPI
module at a time. Once it passes pylint or mypy checks, those checks are
enabled for that file.

Type hints are added in patches that add *only* type hints and change no
other behavior. Any necessary changes to behavior to accommodate typing
are split out into their own tiny patches.

Notes:

- After patch 07, `isort -c` should pass 100% on this and every
   future commit.

- After patch 08, `flake8 qapi/` should pass 100% on this and every
   future commit.

- After patch 09, `pylint --rcfile=qapi/pylintrc qapi/` should pass 100%
   on this and every future commit.

- After patch 18, `mypy --config-file=qapi/mypy.ini qapi/` should pass
   100% on this and every future commit.

Series
Reviewed-by: Markus Armbruster <armbru@redhat.com>

Queued, thanks!


Thanks for putting up with me!

Only five left to go! Enjoy your PTO.

--js




reply via email to

[Prev in Thread] Current Thread [Next in Thread]