Re: does make check now require TCG? Or is it a parallelism issue?

[Claudio Fontana]

On 10/9/20 1:49 PM, Paolo Bonzini wrote:
> On 09/10/20 12:28, Claudio Fontana wrote:
>> Running test qtest-x86_64: qos-test
>> ERROR qtest-x86_64: bios-tables-test - too few tests run (expected 23, got 
>> 22)
>> make: *** [Makefile.mtest:1326: run-test-187] Error 1
>> make: *** Waiting for unfinished jobs....
>>
>> What am I missing here?
> 
> This is something else that is crashing.
> 
> You want to do (as for any other test; this should be documented)
> 
>   make -j12 check-qtest V=1
> 
> and then cut-and-paste the bios-tables-test line, which should be something 
> like
> 
>   QTEST_QEMU_IMG=./qemu-img \
>     
> G_TEST_DBUS_DAEMON=/home/pbonzini/work/upstream/qemu/tests/dbus-vmstate-daemon.sh
>  \
>     QTEST_QEMU_BINARY=./qemu-system-x86_64 \
>     tests/qtest/bios-tables-test --tap -k
> 
> Paolo
> 

Hi Paolo,

I now just found out that bios-tables-test actually was segfaulting, but even 
with V=1
there was no indication or hint about it from the tests, maybe there should be?

Segfault seems to be stemming from a missing check for NULL in the free 
function for the test data,
with that change things seem to finally work for bios-tables-test.

Now to the next failing test.. (qos-test buzzes with no output, we'll see..)

Thanks,

Claudio