[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/10] migration queue
From: |
Peter Xu |
Subject: |
Re: [PULL 00/10] migration queue |
Date: |
Thu, 8 Oct 2020 14:51:14 -0400 |
On Thu, Oct 08, 2020 at 05:18:14PM +0100, Peter Maydell wrote:
> Compile failure, windows crossbuilds:
>
> ../../migration/migration.c: In function 'page_request_addr_cmp':
> ../../migration/migration.c:148:23: error: cast from pointer to
> integer of different size [-Werror=pointer-to-int-cast]
> unsigned long a = (unsigned long) ap, b = (unsigned long) bp;
> ^
> ../../migration/migration.c:148:47: error: cast from pointer to
> integer of different size [-Werror=pointer-to-int-cast]
> unsigned long a = (unsigned long) ap, b = (unsigned long) bp;
> ^
Below squashed into "migration: Maintain postcopy faulted addresses" should fix
the problem:
------8<------
diff --git a/migration/migration.c b/migration/migration.c
index e7d179bffc..d8a5c0de44 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -145,7 +145,7 @@ static void migrate_fd_cancel(MigrationState *s);
static gint page_request_addr_cmp(gconstpointer ap, gconstpointer bp)
{
- unsigned long a = (unsigned long) ap, b = (unsigned long) bp;
+ uintptr_t a = (uintptr_t) ap, b = (uintptr_t) bp;
return (a > b) - (a < b);
}
------8<------
A whole replacement patch attached too.
Thanks!
--
Peter Xu
0001-migration-Maintain-postcopy-faulted-addresses.patch
Description: Text document
- [PULL 06/10] migration: Introduce migrate_send_rp_message_req_pages(), (continued)
- [PULL 06/10] migration: Introduce migrate_send_rp_message_req_pages(), Dr. David Alan Gilbert (git), 2020/10/07
- [PULL 04/10] virtiofsd: avoid /proc/self/fd tempdir, Dr. David Alan Gilbert (git), 2020/10/07
- [PULL 07/10] migration: Maintain postcopy faulted addresses, Dr. David Alan Gilbert (git), 2020/10/07
- [PULL 08/10] migration: Sync requested pages after postcopy recovery, Dr. David Alan Gilbert (git), 2020/10/07
- [PULL 10/10] migration/dirtyrate: present dirty rate only when querying the rate has completed, Dr. David Alan Gilbert (git), 2020/10/07
- [PULL 09/10] migration/dirtyrate: record start_time and calc_time while at the measuring state, Dr. David Alan Gilbert (git), 2020/10/07
- Re: [PULL 00/10] migration queue, Peter Maydell, 2020/10/08
- [PULL 00/10] migration queue, Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 01/10] virtiofsd: Silence gcc warning, Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 02/10] tools/virtiofsd: add support for --socket-group, Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 03/10] virtiofsd: Call qemu_init_exec_dir, Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 04/10] virtiofsd: avoid /proc/self/fd tempdir, Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 05/10] migration: Pass incoming state into qemu_ufd_copy_ioctl(), Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 06/10] migration: Introduce migrate_send_rp_message_req_pages(), Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 07/10] migration: Maintain postcopy faulted addresses, Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 08/10] migration: Sync requested pages after postcopy recovery, Dr. David Alan Gilbert (git), 2020/10/08