Re: [PATCH v2] mingw: fix error __USE_MINGW_ANSI_STDIO redefined

[Stefan Weil]

Am 08.10.20 um 18:59 schrieb marcandre.lureau@redhat.com:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Always put osdep.h first, and remove redundant stdlib.h include.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   migration/dirtyrate.c | 3 ++-
>   tests/test-bitmap.c   | 1 -
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> index 68577ef250..47f761e67a 100644
> --- a/migration/dirtyrate.c
> +++ b/migration/dirtyrate.c
> @@ -10,8 +10,9 @@
>    * See the COPYING file in the top-level directory.
>    */
>   
> -#include <zlib.h>
>   #include "qemu/osdep.h"
> +
> +#include <zlib.h>
>   #include "qapi/error.h"
>   #include "cpu.h"
>   #include "qemu/config-file.h"
> diff --git a/tests/test-bitmap.c b/tests/test-bitmap.c
> index 2f5b71458a..8db4f67883 100644
> --- a/tests/test-bitmap.c
> +++ b/tests/test-bitmap.c
> @@ -8,7 +8,6 @@
>    * Author: Peter Xu <peterx@redhat.com>
>    */
>   
> -#include <stdlib.h>
>   #include "qemu/osdep.h"
>   #include "qemu/bitmap.h"
>   


Reviewed-by: Stefan Weil <sw@weilnetz.de>

Thank you,
Stefan