[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] hw/arm: Restrict APEI tables generation to the 'virt' mac
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2] hw/arm: Restrict APEI tables generation to the 'virt' machine |
Date: |
Thu, 8 Oct 2020 18:13:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 10/8/20 12:50 PM, Peter Maydell wrote:
> On Thu, 1 Oct 2020 at 17:22, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>
>> While APEI is a generic ACPI feature (usable by X86 and ARM64), only
>> the 'virt' machine uses it, by enabling the RAS Virtualization. See
>> commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option").
>>
>> Restrict the APEI tables generation code to the single user: the virt
>> machine. If another machine wants to use it, it simply has to 'select
>> ACPI_APEI' in its Kconfig.
>>
>> Fixes: aa16508f1d ("ACPI: Build related register address fields via hardware
>> error fw_cfg blob")
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> Reviewed-by: Dongjiu Geng <gengdongjiu@huawei.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> v2: Reworded
>>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Xiang Zheng <zhengxiang9@huawei.com>
>> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>> Cc: Igor Mammedov <imammedo@redhat.com>
>> ---
>> default-configs/arm-softmmu.mak | 1 -
>> hw/arm/Kconfig | 1 +
>> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> I assume this needs a respin now Paolo's reworking of
> default-configs/ has gone into master.
Ah indeed. The diff is simply:
-default-configs/arm-softmmu.mak
+default-configs/devices/arm-softmmu.mak
I'll send a v3, thanks for updating me.
>
> thanks
> -- PMM
>