[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/21] qom: Improve error message displayed with missing object pr
From: |
Eduardo Habkost |
Subject: |
[PULL 09/21] qom: Improve error message displayed with missing object properties |
Date: |
Tue, 6 Oct 2020 18:09:18 -0400 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Instead of only displaying the property missing, also display
the object name. This help developer to quickly figure out the
mistake without opening a debugger.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200920155340.401482-1-f4bug@amsat.org>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
qom/object.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qom/object.c b/qom/object.c
index c335dce7e4..1065355233 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1291,7 +1291,8 @@ ObjectProperty *object_property_find_err(Object *obj,
const char *name,
{
ObjectProperty *prop = object_property_find(obj, name);
if (!prop) {
- error_setg(errp, "Property '.%s' not found", name);
+ error_setg(errp, "Property '%s.%s' not found",
+ object_get_typename(obj), name);
}
return prop;
}
--
2.26.2
- [PULL 00/21] machine + QOM queue, 2020-10-06, Eduardo Habkost, 2020/10/06
- [PULL 01/21] hw/core/qdev-properties: Use qemu_strtol() in set_mac() handler, Eduardo Habkost, 2020/10/06
- [PULL 03/21] hw/core/qdev-properties: Fix code style, Eduardo Habkost, 2020/10/06
- [PULL 02/21] hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr(), Eduardo Habkost, 2020/10/06
- [PULL 04/21] hw/core/qdev-properties: Export enum-related functions, Eduardo Habkost, 2020/10/06
- [PULL 05/21] hw/core/qdev-properties: Export qdev_prop_enum, Eduardo Habkost, 2020/10/06
- [PULL 06/21] hw/core/qdev-properties: Export some integer-related functions, Eduardo Habkost, 2020/10/06
- [PULL 09/21] qom: Improve error message displayed with missing object properties,
Eduardo Habkost <=
- [PULL 08/21] hw/core/cpu: Add missing 'exec/cpu-common.h' include, Eduardo Habkost, 2020/10/06
- [PULL 18/21] qom: Explicitly tag doc comments for typedefs and structs, Eduardo Habkost, 2020/10/06
- [PULL 14/21] docs/devel/qom: Remove usage of <code>, Eduardo Habkost, 2020/10/06
- [PULL 10/21] qom: Fix DECLARE_*CHECKER documentation, Eduardo Habkost, 2020/10/06
- [PULL 07/21] hw/core/qdev-properties: Extract system-mode specific properties, Eduardo Habkost, 2020/10/06
- [PULL 17/21] kernel-doc: Handle function typedefs without asterisks, Eduardo Habkost, 2020/10/06
- [PULL 19/21] memory: Explicitly tag doc comments for structs, Eduardo Habkost, 2020/10/06
- [PULL 11/21] docs/devel/qom: Fix indentation of bulleted list, Eduardo Habkost, 2020/10/06
- [PULL 13/21] docs/devel/qom: Use *emphasis* for emphasis, Eduardo Habkost, 2020/10/06
- [PULL 12/21] docs/devel/qom: Fix indentation of code blocks, Eduardo Habkost, 2020/10/06