Re: [PULL 27/37] migration: introduce icount field for snapshots

[Eric Blake]

On 10/6/20 2:29 AM, Paolo Bonzini wrote:
> From: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
> 
> Saving icount as a parameters of the snapshot allows navigation between
> them in the execution replay scenario.
> This information can be used for finding a specific snapshot for proceeding
> the recorded execution to the specific moment of the time.
> E.g., 'reverse step' action (introduced in one of the following patches)
> needs to load the nearest snapshot which is prior to the current moment
> of time.
> This patch also updates snapshot test which verifies qemu monitor output.
> 
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> Acked-by: Markus Armbruster <armbru@redhat.com>
> Acked-by: Kevin Wolf <kwolf@redhat.com>
> 
> --

This is not the usual git-am separator...

> 
> v4 changes:
>  - squashed format update with test output update
> v7 changes:
>  - introduced the spaces between the fields in snapshot info output
>  - updated the test to match new field widths
> Message-Id: 
> <160174518865.12451.14327573383978752463.stgit@pasha-ThinkPad-X280>
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

which makes the extra lines before the final S-o-b look odd.  If the
pull request needs respinning for other reasons, this might be worth
touching up, but it's not worth a respin on its own.


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature