Re: [PATCH v2 2/3] qga: add implementation of guest-get-disks for Linux

[Marc-André Lureau]

Hi

On Tue, Oct 6, 2020 at 12:31 PM Tomáš Golembiovský <tgolembi@redhat.com> wrote:

On Tue, Sep 29, 2020 at 07:22:00PM +0400, Marc-André Lureau wrote:

> > +        if (getline(&line, &n, fp) == -1) {
> > +            g_debug("  failed to read disk size");
> >
>
> line: getline(3) "This buffer should be freed by the user program even if
> getline() failed."

That is handled by the g_autofree, or am I missing something? `line`
will get out of scope after every interation (even with continue). Or do

 

Ah right, I got confused.

thanks

--

Marc-André Lureau