[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete}
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands |
Date: |
Mon, 05 Oct 2020 14:45:29 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Daniel P. Berrangé <berrange@redhat.com> writes:
> On Mon, Oct 05, 2020 at 09:26:54AM +0200, Markus Armbruster wrote:
>> Eric Blake <eblake@redhat.com> writes:
>>
>> > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote:
>> >
>> > Do we have a query- command handy to easily learn which snapshot names
>> > are even available to attempt deletion on? If not, that's worth a
>> > separate patch.
>>
>> Oh, I missed that one. It's the QMP equivalent to "info snapshots", and
>> it is required to finish the job. Since we're at v5, I'd be okay with a
>> follow-up patch, as long as it is done for 5.2.
>
> "query-named-block-nodes" returns BlockDeviceInfo struct, which
> contains ImageInfo which contains an array of SnapshotInfo. So
> we don't need any new query command.
My Acked-by stands without a new query then.
- [PATCH v5 04/10] block: allow specifying name of block device for vmstate storage, (continued)
- [PATCH v5 04/10] block: allow specifying name of block device for vmstate storage, Daniel P . Berrangé, 2020/10/02
- [PATCH v5 05/10] block: rename and alter bdrv_all_find_snapshot semantics, Daniel P . Berrangé, 2020/10/02
- [PATCH v5 06/10] migration: control whether snapshots are ovewritten, Daniel P . Berrangé, 2020/10/02
- [PATCH v5 07/10] migration: wire up support for snapshot device selection, Daniel P . Berrangé, 2020/10/02
- [PATCH v5 08/10] migration: introduce a delete_snapshot wrapper, Daniel P . Berrangé, 2020/10/02
- [PATCH v5 09/10] iotests: add support for capturing and matching QMP events, Daniel P . Berrangé, 2020/10/02
- [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands, Daniel P . Berrangé, 2020/10/02
- Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands, Eric Blake, 2020/10/02
- Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands, Markus Armbruster, 2020/10/05
- Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands, Daniel P . Berrangé, 2020/10/05
- Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands,
Markus Armbruster <=
- Re: [PATCH v5 10/10] migration: introduce snapshot-{save,load,delete} QMP commands, Daniel P . Berrangé, 2020/10/05
- Re: [PATCH v5 10/10] migration: introduce snapshot-{save,load,delete} QMP commands, Dr. David Alan Gilbert, 2020/10/06