[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 4/8] linux-user/elfload: Fix coding style in load_elf_ima
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v10 4/8] linux-user/elfload: Fix coding style in load_elf_image |
|
Date: |
Sat, 3 Oct 2020 19:34:42 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 10/2/20 11:59 PM, Richard Henderson wrote:
> Fixing this now will clarify following patches.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> linux-user/elfload.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index f6022fd704..7572a32a30 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -2531,9 +2531,15 @@ static void load_elf_image(const char *image_name, int
> image_fd,
> abi_ulong vaddr, vaddr_po, vaddr_ps, vaddr_ef, vaddr_em,
> vaddr_len;
> int elf_prot = 0;
>
> - if (eppnt->p_flags & PF_R) elf_prot = PROT_READ;
> - if (eppnt->p_flags & PF_W) elf_prot |= PROT_WRITE;
> - if (eppnt->p_flags & PF_X) elf_prot |= PROT_EXEC;
> + if (eppnt->p_flags & PF_R) {
> + elf_prot |= PROT_READ;
> + }
> + if (eppnt->p_flags & PF_W) {
> + elf_prot |= PROT_WRITE;
> + }
> + if (eppnt->p_flags & PF_X) {
> + elf_prot |= PROT_EXEC;
> + }
>
> vaddr = load_bias + eppnt->p_vaddr;
> vaddr_po = TARGET_ELF_PAGEOFFSET(vaddr);
>
- [PATCH v10 0/8] linux-user: User support for AArch64 BTI, Richard Henderson, 2020/10/02
- [PATCH v10 1/8] linux-user/aarch64: Reset btype for signals, Richard Henderson, 2020/10/02
- [PATCH v10 2/8] linux-user: Set PAGE_TARGET_1 for TARGET_PROT_BTI, Richard Henderson, 2020/10/02
- [PATCH v10 3/8] include/elf: Add defines related to GNU property notes for AArch64, Richard Henderson, 2020/10/02
- [PATCH v10 4/8] linux-user/elfload: Fix coding style in load_elf_image, Richard Henderson, 2020/10/02
- [PATCH v10 5/8] linux-user/elfload: Adjust iteration over phdr, Richard Henderson, 2020/10/02
- [PATCH v10 7/8] linux-user/elfload: Parse NT_GNU_PROPERTY_TYPE_0 notes, Richard Henderson, 2020/10/02
- [PATCH v10 6/8] linux-user/elfload: Move PT_INTERP detection to first loop, Richard Henderson, 2020/10/02