Re: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros

[Philippe Mathieu-Daudé]

On 9/30/20 11:22 PM, Taylor Simpson wrote:
>> -----Original Message-----
>> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On
>> Behalf Of Philippe Mathieu-Daudé
>> Sent: Tuesday, September 29, 2020 6:34 AM
>> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
>> Cc: richard.henderson@linaro.org; laurent@vivier.eu; riku.voipio@iki.fi;
>> aleksandar.m.mail@gmail.com; ale@rev.ng
>> Subject: Re: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros
>>
>> On 9/28/20 7:28 PM, Taylor Simpson wrote:
>>> macros to interface with the generator
>>> macros referenced in instruction semantics
>>>
>>> +#ifndef HEXAGON_MACROS_H
>>> +#define HEXAGON_MACROS_H
>>> +
>>> +#include "qemu/osdep.h"
>>
>> Please do not include "qemu/osdep.h" in header.
>>
>>> +#include "qemu/host-utils.h"
>>
>> "qemu/host-utils.h" doesn't seem used.
>>
>>> +#include "cpu.h"
>>> +#include "hex_regs.h"
>>> +#include "reg_fields.h"
>>> +
>> [...]
> 
> To clarify, does the "[...]" mean I should remove all the includes (and 
> include them in the .c files that include this header file)?

No! No further comment on the rest of this patch, so to avoid you
looking for any comment, I simply stripped the rest. ;)

> 
> Thanks,
> Taylor
> 
>