qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros


From: Taylor Simpson
Subject: RE: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros
Date: Wed, 30 Sep 2020 21:22:03 +0000


> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, September 29, 2020 6:34 AM
> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> Cc: richard.henderson@linaro.org; laurent@vivier.eu; riku.voipio@iki.fi;
> aleksandar.m.mail@gmail.com; ale@rev.ng
> Subject: Re: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros
>
> On 9/28/20 7:28 PM, Taylor Simpson wrote:
> > macros to interface with the generator
> > macros referenced in instruction semantics
> >
> > +#ifndef HEXAGON_MACROS_H
> > +#define HEXAGON_MACROS_H
> > +
> > +#include "qemu/osdep.h"
>
> Please do not include "qemu/osdep.h" in header.
>
> > +#include "qemu/host-utils.h"
>
> "qemu/host-utils.h" doesn't seem used.
>
> > +#include "cpu.h"
> > +#include "hex_regs.h"
> > +#include "reg_fields.h"
> > +
> [...]

To clarify, does the "[...]" mean I should remove all the includes (and include 
them in the .c files that include this header file)?

Thanks,
Taylor



reply via email to

[Prev in Thread] Current Thread [Next in Thread]