[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros
From: |
Taylor Simpson |
Subject: |
RE: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros |
Date: |
Wed, 30 Sep 2020 21:22:03 +0000 |
> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, September 29, 2020 6:34 AM
> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> Cc: richard.henderson@linaro.org; laurent@vivier.eu; riku.voipio@iki.fi;
> aleksandar.m.mail@gmail.com; ale@rev.ng
> Subject: Re: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros
>
> On 9/28/20 7:28 PM, Taylor Simpson wrote:
> > macros to interface with the generator
> > macros referenced in instruction semantics
> >
> > +#ifndef HEXAGON_MACROS_H
> > +#define HEXAGON_MACROS_H
> > +
> > +#include "qemu/osdep.h"
>
> Please do not include "qemu/osdep.h" in header.
>
> > +#include "qemu/host-utils.h"
>
> "qemu/host-utils.h" doesn't seem used.
>
> > +#include "cpu.h"
> > +#include "hex_regs.h"
> > +#include "reg_fields.h"
> > +
> [...]
To clarify, does the "[...]" mean I should remove all the includes (and include
them in the .c files that include this header file)?
Thanks,
Taylor
- Re: [RFC PATCH v4 19/29] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree, (continued)
- [RFC PATCH v4 12/29] Hexagon (target/hexagon) instruction attributes, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 09/29] Hexagon (target/hexagon) architecture types, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 17/29] Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 20/29] Hexagon (target/hexagon) generater phase 4 - decode tree, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 14/29] Hexagon (target/hexagon) instruction printing, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 23/29] Hexagon (target/hexagon) instruction classes, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 15/29] Hexagon (target/hexagon) utility functions, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 29/29] Hexagon build infrastructure, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 18/29] Hexagon (target/hexagon) generator phase 2 - generate header files, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 16/29] Hexagon (target/hexagon/imported) arch import, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 21/29] Hexagon (target/hexagon) opcode data structures, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 25/29] Hexagon (target/hexagon) TCG for instructions with multiple definitions, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 24/29] Hexagon (target/hexagon) TCG generation, Taylor Simpson, 2020/09/28
- [RFC PATCH v4 26/29] Hexagon (target/hexagon) translation, Taylor Simpson, 2020/09/28