Re: [PATCH v5 03/14] hw/block/nvme: Introduce the Namespace Types definitions

[Klaus Jensen]

On Sep 28 11:35, Dmitry Fomichev wrote:
> From: Niklas Cassel <niklas.cassel@wdc.com>
> 
> Define the structures and constants required to implement
> Namespace Types support.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
> ---
>  hw/block/nvme-ns.h   |  2 ++
>  hw/block/nvme.c      |  2 +-
>  include/block/nvme.h | 74 +++++++++++++++++++++++++++++++++++---------
>  3 files changed, 63 insertions(+), 15 deletions(-)
> 
> diff --git a/hw/block/nvme-ns.h b/hw/block/nvme-ns.h
> index 83734f4606..cca23bc0b3 100644
> --- a/hw/block/nvme-ns.h
> +++ b/hw/block/nvme-ns.h
> @@ -21,6 +21,8 @@
>  
>  typedef struct NvmeNamespaceParams {
>      uint32_t nsid;
> +    uint8_t  csi;
> +    QemuUUID uuid;
>  } NvmeNamespaceParams;

The motivation behind the NvmeNamespaceParams was to only keep user
visible parameters in this struct.

Can we move csi/uuid to the NvmeNamespace struct?

signature.asc
Description: PGP signature