qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qcow2: Use L1E_SIZE in qcow2_write_l1_entry()


From: Eric Blake
Subject: Re: [PATCH] qcow2: Use L1E_SIZE in qcow2_write_l1_entry()
Date: Tue, 29 Sep 2020 11:08:27 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/28/20 11:23 AM, Alberto Garcia wrote:
> We overlooked these in 02b1ecfa100e7ecc2306560cd27a4a2622bfeb04
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  block/qcow2-cluster.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

> diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
> index 9acc6ce4ae..aa87d3e99b 100644
> --- a/block/qcow2-cluster.c
> +++ b/block/qcow2-cluster.c
> @@ -240,14 +240,14 @@ int qcow2_write_l1_entry(BlockDriverState *bs, int 
> l1_index)
>      }
>  
>      ret = qcow2_pre_write_overlap_check(bs, QCOW2_OL_ACTIVE_L1,
> -            s->l1_table_offset + 8 * l1_start_index, bufsize, false);
> +            s->l1_table_offset + L1E_SIZE * l1_start_index, bufsize, false);
>      if (ret < 0) {
>          return ret;
>      }
>  
>      BLKDBG_EVENT(bs->file, BLKDBG_L1_UPDATE);
>      ret = bdrv_pwrite_sync(bs->file,
> -                           s->l1_table_offset + 8 * l1_start_index,
> +                           s->l1_table_offset + L1E_SIZE * l1_start_index,
>                             buf, bufsize);
>      if (ret < 0) {
>          return ret;
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]